Repository navigation
fix: Normalize s3 paths for PME key retriever - #2874
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2874 +/- ##
============================================
+ Coverage 56.12% 59.28% +3.15%
- Complexity 976 1345 +369
============================================
Files 119 167 +48
Lines 11743 15306 +3563
Branches 2251 2536 +285
============================================
+ Hits 6591 9074 +2483
- Misses 4012 4944 +932
- Partials 1140 1288 +148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
reviewed
Dec 11, 2025
…apper.java Co-authored-by: Andy Grove <agrove@apache.org>
andygrove
reviewed
Dec 11, 2025
| assert(df.first().getLong(0) == 499500) | ||
| } | ||
|
|
||
| test("write and read encrypted parquet from S3") { |
Member
There was a problem hiding this comment.
I don't know if this test exercises the changes to normalizing the path or not, but the test looks good
Contributor
Author
There was a problem hiding this comment.
It did fail on main, FWIW.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2871.
Rationale for this change
What changes are included in this PR?
Normalize s3 paths in the key retriever cache.
How are these changes tested?
Added a test that fails on main
native_datafusionParquet reader. With this change, the test passes.