Repository navigation
fix: enable cast tests for Spark 4.0 - #2919
Merged
Merged
Conversation
manuzhang
force-pushed
the
cast-test-spark4.0
branch
from
December 17, 2025 00:40
8ab922b to
f361558
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2919 +/- ##
============================================
+ Coverage 56.12% 59.61% +3.48%
- Complexity 976 1370 +394
============================================
Files 119 167 +48
Lines 11743 15493 +3750
Branches 2251 2568 +317
============================================
+ Hits 6591 9236 +2645
- Misses 4012 4957 +945
- Partials 1140 1300 +160 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coderfender
requested changes
Dec 17, 2025
Contributor
|
Closes : #2885 |
manuzhang
force-pushed
the
cast-test-spark4.0
branch
3 times, most recently
from
December 18, 2025 04:23
9b55e22 to
04e1ffd
Compare
coderfender
approved these changes
Dec 18, 2025
Contributor
|
@manuzhang , LGTM nit : would be great to have a separate unit test to check error messages themselves . |
Member
Author
|
@coderfender which message do you suggest to expect specifically? Spark has added back "SQLSTATE" tag in 4.1 but I don't think we have to change at Comet side to match the behavior every time. |
Contributor
|
@manuzhang no I meant a simple unit test to asset that our logic works :) |
manuzhang
force-pushed
the
cast-test-spark4.0
branch
from
December 20, 2025 15:25
04e1ffd to
e90e39f
Compare
manuzhang
force-pushed
the
cast-test-spark4.0
branch
from
December 21, 2025 08:43
e90e39f to
23f0ded
Compare
manuzhang
force-pushed
the
cast-test-spark4.0
branch
from
December 22, 2025 02:52
23f0ded to
d27b6b3
Compare
Contributor
|
Thank you @manuzhang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2885.
Rationale for this change
Some cast tests are skipped for Spark 4.0 due to exception message mismatch after apache/spark#48054.
What changes are included in this PR?
Drop
If necessary set \"spark.sql.ansi.enabled\" to \"false\" to bypass this error.from comet exception message like apache/spark#48054, and enable tests skipped for Spark 4.0.How are these changes tested?