Repository navigation
fix: Spark 4.0 SparkArithmeticException test - #688
Merged
kazuyukitanimura merged 6 commits intoJul 20, 2024
Merged
kazuyukitanimura merged 6 commits into
kazuyukitanimura merged 6 commits into
Conversation
kazuyukitanimura
marked this pull request as ready for review
July 19, 2024 17:11
kazuyukitanimura
requested review from
andygrove,
comphead,
huaxingao and
viirya
July 20, 2024 01:09
viirya
approved these changes
Jul 20, 2024
Contributor
Author
|
Merged thanks @parthchandra @viirya |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
## Which issue does this PR close? Part of apache#372 and apache#551 ## Rationale for this change To be ready for Spark 4.0 ## What changes are included in this PR? This PR fixes the test that requires to see SparkArithmeticException ## How are these changes tested? Enabled `SPARK-40389: Don't eliminate a cast which can cause overflow`
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
## Which issue does this PR close? N/A ## Rationale for this change Apple Iceberg `1.5.0.x` branch has merged the diff so it is no longer needed. ## What changes are included in this PR? - Don't apply diff in Rio - Remove diff ## How are these changes tested? Unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #372 and #551
Rationale for this change
To be ready for Spark 4.0
What changes are included in this PR?
This PR fixes the test that requires to see SparkArithmeticException
How are these changes tested?
Enabled
SPARK-40389: Don't eliminate a cast which can cause overflow