Repository navigation
Add "timezone_region" and "timezone_abbr" support for EXTRACT (and DATE_PART) - #1090
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 7527965721
💛 - Coveralls |
EXTRACT and DATE_PARTEXTRACT and DATE_PART
alexander-beedie
force-pushed
the
extract-timezone-region
branch
from
January 15, 2024 07:04
8aed07f to
86ed5fb
Compare
EXTRACT and DATE_PARTEXTRACT (and DATE_PART)
alamb
reviewed
Jan 15, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution @alexander-beedie - the code and tests look good in this PR . I am not sure about the commented out test however.
alexander-beedie
force-pushed
the
extract-timezone-region
branch
from
January 15, 2024 11:06
7198258 to
39f7a23
Compare
3 of 9 tasks
Contributor
Author
Fixed; sorry about that one ;) |
alamb
approved these changes
Jan 16, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
LGTM -- thanks again @alexander-beedie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "timezone_region" and "timezone_abbr"1 as recognised
DateTimeFieldvalues.Footnotes
Oracle: EXTRACT docs ↩