Skip to content

feat: support tailing commas on snowflake dialect. - #1205

Merged
alamb merged 4 commits into
apache:mainfrom
ya7010:support_tailing_comma_on_snowflake
Apr 9, 2024
Merged

alamb merged 4 commits into
apache:mainfrom
ya7010:support_tailing_comma_on_snowflake

Conversation

@ya7010

@ya7010 ya7010 commented Apr 7, 2024

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @yassun7010

Can you please add a test for this change?

@ya7010

ya7010 commented Apr 8, 2024

Copy link
Copy Markdown
Contributor Author

@alamb

Of course! I added it.

@ya7010
ya7010 requested a review from alamb April 9, 2024 00:40

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yassun7010 🙏

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8593655656

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 88.004%

Totals Coverage Status
Change from base Build 8588850954: 0.001%
Covered Lines: 20813
Relevant Lines: 23650

💛 - Coveralls

@alamb
alamb merged commit 6da8828 into apache:main Apr 9, 2024
lustefaniak pushed a commit to getsynq/sqlparser-rs that referenced this pull request Apr 10, 2024
JichaoS pushed a commit to luabase/sqlparser-rs that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants