Skip to content

Support CREATE/DROP SECRET for duckdb dialect - #1208

Merged
alamb merged 9 commits into
apache:mainfrom
alamb:jichaos/secrets
Apr 9, 2024
Merged

alamb merged 9 commits into
apache:mainfrom
alamb:jichaos/secrets

Conversation

@alamb

@alamb alamb commented Apr 9, 2024 •

Copy link
Copy Markdown
Contributor

This is a cleaned up version of #1196 from @JichaoS that has:

  1. Merge up from main
  2. Fixed fmt and clippy and doc tests

Closes #1196

@alamb
alamb merged commit 241da85 into apache:main Apr 9, 2024
@alamb
alamb deleted the jichaos/secrets branch April 9, 2024 20:21
@github-actions

github-actions Bot commented Apr 9, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8621756431

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 217 of 255 (85.1%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 87.971%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 85 103 82.52%
src/ast/mod.rs 60 80 75.0%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 2 80.09%
Totals Coverage Status
Change from base Build 8588850954: -0.03%
Covered Lines: 21026
Relevant Lines: 23901

💛 - Coveralls

JichaoS added a commit to luabase/sqlparser-rs that referenced this pull request May 7, 2024
Co-authored-by: Jichao Sun <4977515+JichaoS@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants