Skip to content

MySQL: Remove duplicate string-introducer arm - #2716

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
remove-duplicate-string-introducer
Oct 26, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
remove-duplicate-string-introducer

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

String introducers for single-quoted, double-quoted, and hexadecimal literals are handled by the first matching arm. The repeated arm can never run.

Addresses the string-introducer duplication tracked in #2698.

Another echoes find.

@LucaCappelletti94 LucaCappelletti94 added MySQL deduplication Removal of duplicated code labels Oct 25, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.23%. Comparing base (72ce6a8) to head (93122d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2716      +/-   ##
==========================================
+ Coverage   82.22%   82.23%   +0.01%     
==========================================
  Files          42       42              
  Lines       35343    35340       -3     
  Branches    35343    35340       -3     
==========================================
+ Hits        29060    29063       +3     
+ Misses       2716     2711       -5     
+ Partials     3567     3566       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

Merging also this as it is a cleanup.

cc @alamb

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit e997a09 Oct 26, 2026
10 checks passed

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deduplication Removal of duplicated code MySQL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants