Skip to content

MySQL: Share column primary-key parsing - #2720

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
converge-column-primary-key
Oct 26, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
converge-column-primary-key

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

A single column-option branch handles PRIMARY KEY and the capability-gated KEY shorthand, including constraint characteristics.

Addresses the column primary-key duplication tracked in #2698.

Another echoes find.

@LucaCappelletti94 LucaCappelletti94 added rust Pull requests that update rust code MySQL deduplication Removal of duplicated code labels Oct 25, 2026
@codecov-commenter

codecov-commenter commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.30%. Comparing base (583c4d4) to head (38154c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2720      +/-   ##
==========================================
- Coverage   82.30%   82.30%   -0.01%     
==========================================
  Files          42       42              
  Lines       35307    35294      -13     
  Branches    35307    35294      -13     
==========================================
- Hits        29058    29047      -11     
+ Misses       2691     2690       -1     
+ Partials     3558     3557       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 force-pushed the converge-column-primary-key branch from 15c4539 to 7aa774a Compare October 26, 2026 18:58
@LucaCappelletti94
LucaCappelletti94 force-pushed the converge-column-primary-key branch from 7aa774a to 38154c1 Compare October 26, 2026 20:18
@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

cc @alamb merging also this echo

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit 27259c1 Oct 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deduplication Removal of duplicated code MySQL rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants