Repository navigation
Conversation
Fixes apache#2818 Signed-off-by: Vincent <ump45nose@users.noreply.github.com>
| # `issues` and `issue_comment` already run from the default branch and are | ||
| # unchanged. | ||
| concurrency: | ||
| group: ${{ github.repository }}-${{ github.event.workflow_run.head_repository.full_name || github.event.issue.number }}-${{ github.event.workflow_run.head_branch || github.event_name }}-${{ github.workflow }} |
There was a problem hiding this comment.
You should give every issues and issue_comment run its own group.
As written, all comments on one pull request share <repo>-<number>-issue_comment-labeler, so with cancel-in-progress: true a second comment arriving while the first run is still working cancels it, and the dialects the first comment declared are never added.
main has no concurrency block, so this drops labels that are applied today, contrary to the "unchanged" comment above it.
| group: ${{ github.repository }}-${{ github.event.workflow_run.head_repository.full_name || github.event.issue.number }}-${{ github.event.workflow_run.head_branch || github.event_name }}-${{ github.workflow }} | |
| group: ${{ github.repository }}-${{ github.event_name == 'workflow_run' && format('{0}-{1}', github.event.workflow_run.head_repository.full_name, github.event.workflow_run.head_branch) || github.run_id }}-${{ github.workflow }} |
There was a problem hiding this comment.
Thanks @LucaCappelletti94 — that cancellation was a real regression against main.
Pushed 17bc5a5 with your suggested group: workflow_run stays keyed by the head repository and branch, and issues / issue_comment now use github.run_id so a later comment cannot cancel an in-progress labeling run.
(AI-assisted reply.)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2891 +/- ##
=======================================
Coverage 83.20% 83.20%
=======================================
Files 42 42
Lines 36471 36471
Branches 36471 36471
=======================================
Hits 30345 30345
Misses 2632 2632
Partials 3494 3494 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A second comment on the same pull request was sharing one concurrency group and cancelling an in-progress issues/issue_comment labeling run, so dialects declared in the cancelled comment were never applied. Main has no concurrency block, so this restores that behavior. Use github.run_id for those events and keep the pull-request workflow_run group keyed by head repository and branch. Signed-off-by: Vincent <ump45nose@users.noreply.github.com>
Dialects: none
What
Migrates the dialect labeler off
pull_request_target, which ASF infra is disabling and GitHub will block by default on 2 December 2026.pull_requestsignal workflow (opened/edited/reopened/synchronize).workflow_runrequestedevent.issuesandissue_commentpaths unchanged.editedis included so a title orDialects:line update still applies labels, matching the current behavior. Therequestedevent fires even while a first-time contributor's checks wait for approval.This follows the current approach in apache/datafusion#26683 rather than uploading a pull request number artifact: that pull request moved to a signal plus an API lookup, which avoids treating PR-produced data as input.
The new pull request path takes effect after this change is on the default branch. Until then, the existing
pull_request_targetworkflow onmaincontinues to label pull requests.Fixes #2818
Tests
node --checkon both labeler scriptsissue_commentpath, andpull_requests_of_run.jscargo test/fmt/clippywere not rerunAI assistance
Prepared with AI assistance. I reviewed the workflow change, the script updates, and the referenced DataFusion pattern before opening this PR.