Repository navigation
Incorrect results: leaf expression pushdown duplicates volatile expressions (random() evaluated twice) #24678
Description
Describe the bug
enable_leaf_expression_pushdown inlines a column's defining expression into each extracted get_field that references it, but performs no volatility check.
To Reproduce
Run this:
datafusion-cli -c "SELECT s, s['a'] AS field FROM (SELECT named_struct('a', random()) AS s FROM generate_series(1,3));"
Expected behavior
field equals s.a on every row.
Additional context
Setting enable_leaf_expression_pushdown = false avoids the bug (makes field equals s.a on every row).
Activity
fornwall commentedon Aug 25, 2026
Seems to be fixed by #23691 (but I have not reviewed or tested that PR extensively, just found that when searching around for the issue).
fornwall commentedon Aug 25, 2026
Does not seem to be a regression, 53 and 54 have the same issue.
fix: do not duplicate volatile expressions when extracting leaf expre…
test: differential fuzz for leaf expression pushdown and parquet filt…
test: differential fuzz for leaf expression pushdown and parquet filt…