Skip to content

Clippy fails with all features enabled #26181

Closed

Description

@haohuaijin

Describe the bug

Running Clippy with all features enabled fails with three clippy::mutable_key_type errors.

This was discovered during local checks for #26180. The errors also occur on the main branch.

To Reproduce

run below command that describe in agent.md

cargo clippy --all-targets --all-features -- -D warnings
╰─$ cargo clippy --all-targets --all-features -- -D warnings
    Checking datafusion-optimizer v55.1.0 (/Users/huaijinhao/gitrepo/apache/datafusion/datafusion/optimizer)
error: mutable key type
    --> datafusion/optimizer/src/push_down_filter.rs:1138:69
     |
1138 |                 fn extract_partition_keys(func: &WindowFunction) -> HashSet<&Expr> {
     |                                                                     ^^^^^^^^^^^^^^
     |
     = note: ... because it contains `&Expr`, which has interior mutability
     = note: ... because it contains `Expr`, which has interior mutability
     = note: ... because it contains `ScalarValue`, which has interior mutability
     = note: ... because it contains `Arc<FixedSizeListArray>`, which has interior mutability
     = note: ... because it contains `FixedSizeListArray`, which has interior mutability
     = note: ... because it contains `Option<NullBuffer>`, which has interior mutability
     = note: ... because it contains `NullBuffer`, which has interior mutability
     = note: ... because it contains `BooleanBuffer`, which has interior mutability
     = note: ... because it contains `Buffer`, which has interior mutability
     = note: ... because it contains `Arc<Bytes>`, which has interior mutability
     = note: ... because it contains `Bytes`, which has interior mutability
     = note: ... because it contains `TrackedReservation`, which has interior mutability
     = note: ... because it contains `Mutex<Option<Box<dyn MemoryReservation>>>`, which has interior mutability
     = note: ... because it contains `Mutex`, which has interior mutability
     = note: ... because it contains `OnceBox<Mutex>`, which has interior mutability
     = note: ... because it contains `Atomic<*mut Mutex>`, which has interior mutability
     = note: ... because it contains `UnsafeCell<<*mut Mutex as AtomicPrimitive>::Storage>`, which has interior mutability
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.99.0/index.html#mutable_key_type
     = note: `-D clippy::mutable-key-type` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::mutable_key_type)]`

error: mutable key type
    --> datafusion/optimizer/src/push_down_filter.rs:1142:17
     |
1142 | /                 let potential_partition_keys = window
1143 | |                     .window_expr
1144 | |                     .iter()
1145 | |                     .map(|e| {
...    |
1168 | |                     .reduce(|a, b| &a & &b)
1169 | |                     .unwrap_or_default();
     | |_________________________________________^
     |
     = note: ... because it contains `&Expr`, which has interior mutability
     = note: ... because it contains `Expr`, which has interior mutability
     = note: ... because it contains `ScalarValue`, which has interior mutability
     = note: ... because it contains `Arc<FixedSizeListArray>`, which has interior mutability
     = note: ... because it contains `FixedSizeListArray`, which has interior mutability
     = note: ... because it contains `Option<NullBuffer>`, which has interior mutability
     = note: ... because it contains `NullBuffer`, which has interior mutability
     = note: ... because it contains `BooleanBuffer`, which has interior mutability
     = note: ... because it contains `Buffer`, which has interior mutability
     = note: ... because it contains `Arc<Bytes>`, which has interior mutability
     = note: ... because it contains `Bytes`, which has interior mutability
     = note: ... because it contains `TrackedReservation`, which has interior mutability
     = note: ... because it contains `Mutex<Option<Box<dyn MemoryReservation>>>`, which has interior mutability
     = note: ... because it contains `Mutex`, which has interior mutability
     = note: ... because it contains `OnceBox<Mutex>`, which has interior mutability
     = note: ... because it contains `Atomic<*mut Mutex>`, which has interior mutability
     = note: ... because it contains `UnsafeCell<<*mut Mutex as AtomicPrimitive>::Storage>`, which has interior mutability
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.99.0/index.html#mutable_key_type

error: mutable key type
    --> datafusion/optimizer/src/push_down_filter.rs:1606:21
     |
1606 |     partition_keys: &HashSet<&Expr>,
     |                     ^^^^^^^^^^^^^^^
     |
     = note: ... because it contains `&Expr`, which has interior mutability
     = note: ... because it contains `Expr`, which has interior mutability
     = note: ... because it contains `ScalarValue`, which has interior mutability
     = note: ... because it contains `Arc<FixedSizeListArray>`, which has interior mutability
     = note: ... because it contains `FixedSizeListArray`, which has interior mutability
     = note: ... because it contains `Option<NullBuffer>`, which has interior mutability
     = note: ... because it contains `NullBuffer`, which has interior mutability
     = note: ... because it contains `BooleanBuffer`, which has interior mutability
     = note: ... because it contains `Buffer`, which has interior mutability
     = note: ... because it contains `Arc<Bytes>`, which has interior mutability
     = note: ... because it contains `Bytes`, which has interior mutability
     = note: ... because it contains `TrackedReservation`, which has interior mutability
     = note: ... because it contains `Mutex<Option<Box<dyn MemoryReservation>>>`, which has interior mutability
     = note: ... because it contains `Mutex`, which has interior mutability
     = note: ... because it contains `OnceBox<Mutex>`, which has interior mutability
     = note: ... because it contains `Atomic<*mut Mutex>`, which has interior mutability
     = note: ... because it contains `UnsafeCell<<*mut Mutex as AtomicPrimitive>::Storage>`, which has interior mutability
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.99.0/index.html#mutable_key_type

error: could not compile `datafusion-optimizer` (lib) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `datafusion-optimizer` (lib test) due to 3 previous errors

Expected behavior

No response

Additional context

No response

Willingness to contribute

None

Activity

  1. added theissue type on Oct 10, 2026
  2. added a commit that references this issue on Oct 23, 2026
    c92d781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions