Incorrect error message for decimal with scale while input value is out of bound

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

❯ select 1::decimal(1, 1);
ArrowError(InvalidArgumentError("10 is too large to store in a Decimal128 of precision 1. Max is 9"))

❯ select 10::decimal(2, 1);
ArrowError(InvalidArgumentError("100 is too large to store in a Decimal128 of precision 2. Max is 99"))

Expected behavior
A clear and concise description of what you expected to happen.

something like

❯ select 10::decimal(2, 1);
ArrowError(InvalidArgumentError("10 is too large to store in a Decimal128 of precision 2  with scale 1. Max is 9.9"))

Additional context
Add any other context about the problem here.

@liukun4515

Is this a parsing error of decimal value? cc @liukun4515

@waitingkuo

@waitingkuo
The error message is not right, we just print the value of i128 for the precision, and don't consider the scale value.

Not sure which PR affects it, but this is what I got with the latest commit in the master branch:

❯ select 1::decimal(1,1);
+----------+
| Int64(1) |
+----------+
| .1       |
+----------+
1 row in set. Query took 0.004 seconds.
❯ select 10::decimal(2,1);
+-----------+
| Int64(10) |
+-----------+
| 1.0       |
+-----------+

@andygrove

cc @andygrove

Fast-forward a few years, and this behavior is back.

select 1::decimal(1, 1);
Arrow error: Invalid argument error: 10 is too large to store in a Decimal128 of precision 1. Max is 9

select 10::decimal(2, 1);
Arrow error: Invalid argument error: 100 is too large to store in a Decimal128 of precision 2. Max is 99

See upstream issue in arrow-rs: apache/arrow-rs#8382

Upgrade DataFusion to arrow/parquet 57.0.0 (#17888)

Upgrade DataFusion to arrow/parquet 57.0.0 (apache#17888)

Navigation Menu

Repository navigation

Incorrect error message for decimal with scale while input value is out of bound #3666

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Incorrect error message for decimal with scale while input value is out of bound #3666

Description

Activity

HaoYang670 commented on Oct 5, 2022

liukun4515 commented on Oct 6, 2022

HaoYang670 commented on Nov 7, 2022

HaoYang670 commented on Nov 7, 2022

drauschenbach commented on Nov 1, 2024

Jefffrey commented on Sep 18, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions