You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
FilterPushdown will generate duplicate exprs #3914
Which contains some duplicate exprs, see the file diff for highlights.
And in #3841@Dandandan run some optimize rules one more time and got the duplicate exprs optimized out. But in #3861 the duplicate exprs will cause another problem when combine with CommonSubexpressionEliminate rule.
Describe the solution you'd like
Besides let other rules to do further optimization (this is useful to make more optimizations), I think it's also important to generate a "good enough" plan from a rule itself (i.e., remove duplications like this in FilterPushdown). So we can cut the dependent graph among individual plans (which is hard to maintain...).
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Activity
alamb commentedon Oct 2, 2023
I wonder if this is still an issue
alamb commentedon Feb 12, 2026
The current plan has no duplicate filters
datafusion/datafusion/sqllogictest/test_files/tpch/plans/q21.slt.part
Lines 79 to 80 in 5fccac1
So I am going to claim this one is fixed