Skip to content

Tests fail if avro feature is not enabled #6399

Closed

Description

@andygrove

Describe the bug

cargo test --all fails with:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: NotImplemented("cannot read avro schema without the 'avro' feature enabled")', datafusion/core/tests/sqllogictests/src/setup.rs:66:10

To Reproduce

No response

Expected behavior

No response

Additional context

No response

Activity

  1. self-assigned this
    on May 20, 2023
  2. alamb commented on May 21, 2023

    @alamb
    Contributor

    I think it is is important that cargo test -p datafusion will pass successfully

    I think we should fix sqllogictest so that it only runs the avro tests when avro is enabled

    The alternative is to default avro to on. I will look into this later today or tomorrow

  3. ozankabak commented on May 23, 2023

    @ozankabak
    Contributor

    Any progress on this? Let's remove this unnecessary friction from the new developer experience. I am fine with both solutions BTW.

  4. mingmwang commented on May 23, 2023

    @mingmwang
    Contributor

    Yes, I encountered the same issue.

  5. alamb commented on May 23, 2023

    @alamb
    Contributor

    Here is a proposed PR to fix: #6429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions