You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
keep the DataFusion code base clean and easy to contribute to and modify
Understand what features are covered and what are not
Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily
I think these are good first issues as they teach the contributor about the DataFusion codebase and tests, as well as see the end user apis in practice.
Note, there is already a groupby.slt test file, which is quite large, but from a quick search does not look to cover the test cases from group_by.rs. I will port the tests to groupby.slt. If we are picky about the name, I can move groupby.slt to group_by.slt as well.
Activity
hiltontj commentedon Jan 10, 2024
I will work on this when I get some spare time.
Note, there is already a
groupby.slttest file, which is quite large, but from a quick search does not look to cover the test cases fromgroup_by.rs. I will port the tests togroupby.slt. If we are picky about the name, I can movegroupby.slttogroup_by.sltas well.alamb commentedon Jan 10, 2024
Thank you @hiltontj -- any improvements you can make in this area are most appreciated