Repository navigation
Port tests in select.rs to sqllogictest #8213
Description
Is your feature request related to a problem or challenge?
Part of #6195. We are trying to
- keep the DataFusion code base clean and easy to contribute to and modify
- Understand what features are covered and what are not
Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily
Describe the solution you'd like
Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/select.rs to
select.slt in https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest/test_files
Note you can create catalogs and schema via SQL now
Catalogs: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-database
Schema: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-schema
Notes:
- Instructions for running sqllogitest are here: https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest
Describe alternatives you've considered
No response
Additional context
I think these are good first issues as they teach the contributor about the DataFusion codebase and tests, as well as see the end user apis in practice.
Activity
fansehep commentedon Nov 20, 2023
i want to try this. 😄
alamb commentedon Jan 21, 2024
This one I think is still a good first issue / maybe even covered by existing tests
Tangruilin commentedon Jan 23, 2024
@alamb maybe this can assign to me
Tangruilin commentedon Jan 23, 2024
I need some help，https://github.com/apache/arrow-datafusion/blob/31b9b48b08592b7d293f46e75707aad7dadd7cbc/datafusion/core/tests/sql/select.rs#L121
Tangruilin commentedon Jan 23, 2024
Here it create a column with struct, but i do not know how to create it by sql
Tangruilin commentedon Jan 23, 2024
@alamb
alamb commentedon Jan 23, 2024
I think you can use the
structfunction:https://arrow.apache.org/datafusion/user-guide/sql/scalar_functions.html#struct-functions
simicd commentedon Jan 24, 2024
Hi both - @Tangruilin seems like we we're working independently on the topic 😮 I had raised two PRs previously but seems they remained unnoticed. Guess we should try to consolidate into a single PR, feel free to take over whatever you're missing currently from #8953 and #8939 and integrate into yours if that's ok with you as well.
In #8939 you will find how I implemented the structs.
Tangruilin commentedon Jan 25, 2024
I have already sloved the problem of struct in my CR.
It seems my CR have sloved this issue.
Tangruilin commentedon Jan 25, 2024
Maybe We can use my CR?
Or do you have some suggestions?
simicd commentedon Jan 25, 2024
Yes sounds good!
alamb commentedon Jan 25, 2024
Yes, sorry -- I am backed up on reviews. I am hoping other committers can find more time to help. I am working to try and get the backlog down
[task #8213]Port tests in select.rs to sqllogictest (#8967)