Repository navigation
collection_size_threshold incorrectly used in supports_collect_by_size #8405
Description
Describe the bug
In supports_collect_by_size, collection_size_threshold to compare the threshold for both total_byte_size (correct), but incorrectly as fallback for num_rows.
This leads to large planning differences for when estimated size is / is not available.
To Reproduce
Read the code.
Expected behavior
As a first step, introduce hash_join_single_partition_threshold_rows, being number of times (e.g. 10x) smaller than the number of bytes. Adapt hash_join_single_partition_threshold as well (may need to increase it).
We also can improve the estimation of size by improving the estimation.
Additional context
No response
Activity
[-]collection_size_threshold incorrectly used[/-][+]`collection_size_threshold` incorrectly used[/+][-]`collection_size_threshold` incorrectly used[/-][+]`collection_size_threshold` incorrectly used in `supports_collect_by_size`[/+]maruschin commentedon Jan 2, 2024
@Dandandan, hi!
I created a draft pull request, did I understand the idea correctly?
Dandandan commentedon Jan 21, 2024
Thank you @maruschin <3