Repository navigation
Use cargo release in bench.sh - #11722
Merged
Merged
Conversation
alamb
marked this pull request as ready for review
July 30, 2024 12:17
jayzhan211
approved these changes
Jul 30, 2024
comphead
approved these changes
Jul 30, 2024
comphead
left a comment
Contributor
There was a problem hiding this comment.
the CI time without nonLTO is the same 😞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
As we get into serious benchmarking / optimization mode, ensuring the benchmark results are as close to what is actually run as possible is important. Thus I want to propose using
cargo releasein bench.sh even if that makes the runs take longer.Most builds of DataFusion use
cargo <cmd> --releaserather thancargo <cmd> --profile release-nonltoFor example, I am not sure why #11718 shows improvements on some environments and not others.
What changes are included in this PR?
bench.shto use--releaseinstead of--relase-non-ltoAre these changes tested?
I am going to run benchmarks on my test rig manually to see if this causes any differences
Are there any user-facing changes?