Repository navigation
Update ClickBench queries to avoid to_timestamp_seconds - #15475
Conversation
adriangb
left a comment
There was a problem hiding this comment.
Looks good to me. Since we're only ordering by this it shouldn't matter that we order by an integer instead of a proper timestamp, ordering is equivalent.
|
Should we update the same query in the clickbench repo as well? |
Yes, and we might rerun the queries as well (as |
Thank you very much for your reply, but I have a question: why can't the following |
I'm agreeing with you! I think this change is good 😄 |
|
I have also made changes to the query in ClickBench: clickbench-pr |
|
@Dandandan do you think we can merge this here? |
|
Thank you @acking-you |
* Update ClickBench queries to avoid to_timestamp_seconds * change more unnecessary type conversions
Which issue does this PR close?
to_timestamp_seconds#15465 .Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?