Skip to content

test: Move default cache tests to default cache file - #23040

Merged
alamb merged 3 commits into
apache:mainfrom
mkleen:mv-cache-tests
Jun 22, 2026
Merged

alamb merged 3 commits into
apache:mainfrom
mkleen:mv-cache-tests

Conversation

@mkleen

@mkleen mkleen commented Jun 19, 2026 •

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes None.

Rationale for this change

Follow-up of #22613 This moves the cache related tests to default_cache.rs where the tests belong to. The tests were previously not moved to have a diff for the review. Now, since #22613 is merged we can move the tests to the right location.

What changes are included in this PR?

See above.

Are these changes tested?

This change only moves tests around.

Are there any user-facing changes?

No.

@github-actions github-actions Bot added the execution Related to the execution crate label Jun 19, 2026
@mkleen mkleen changed the title Move cache tests into default_cache Move cache tests to default cache Jun 19, 2026
@mkleen
mkleen marked this pull request as ready for review June 19, 2026 11:35
@mkleen mkleen changed the title Move cache tests to default cache refactor: Move cache tests to default cache Jun 19, 2026
@mkleen mkleen changed the title refactor: Move cache tests to default cache minor: Move cache tests to default cache Jun 19, 2026
@mkleen mkleen changed the title minor: Move cache tests to default cache minor: Move default cache tests to default cache Jun 19, 2026
@mkleen mkleen changed the title minor: Move default cache tests to default cache minor: Move default cache tests to default cache file Jun 19, 2026
@mkleen mkleen changed the title minor: Move default cache tests to default cache file test: Move default cache tests to default cache file Jun 19, 2026

@nuno-faria nuno-faria left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkleen, LGTM.

Comment thread datafusion/execution/src/cache/default_cache.rs
@mkleen

mkleen commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

@nuno-faria Thanks for the review!

@alamb
alamb added this pull request to the merge queue Jun 22, 2026
@alamb

alamb commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

🚀

Merged via the queue into apache:main with commit a4c4b4d Jun 22, 2026
36 checks passed
@mkleen
mkleen deleted the mv-cache-tests branch July 19, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execution Related to the execution crate v55.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants