Repository navigation
feat: Expose cache hits in statistics_cache function - #23253
Merged
Merged
Conversation
mkleen
marked this pull request as ready for review
June 30, 2026 08:42
alamb
approved these changes
Jun 30, 2026
| +-----------------------------------+---------------------------+-----------------+--------------+-------------+------+------------------+ | ||
| | filename | table | file_size_bytes | num_rows | num_columns | hits | table_size_bytes | | ||
| +-----------------------------------+---------------------------+-----------------+--------------+-------------+------+------------------+ | ||
| | alltypes_plain.parquet | alltypes_plain | 1851 | Exact(8) | 11 | 3 | Absent | |
Contributor
Author
|
@alamb Thanks for the review! |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 1, 2026
mkleen
added a commit
to mkleen/datafusion
that referenced
this pull request
Jul 13, 2026
## Which issue does this PR close? - Closes None. ## Rationale for this change Follow up to apache#22613 and apache#23253. Cache hits are now supported for all memory-limiting caches. Therefore it makes sense to expose them in the `list_files_cache` function the same way the `metadata_cache` and `statistics_cache` functions do it already. ## What changes are included in this PR? - Add cache hits to the `list_files_cache` function - Tests - Adapt documentation for the `list_files_cache` function ## Are these changes tested? Yes. ## Are there any user-facing changes? Yes, the `list_files_cache` function supports now cache hits but no breaking changes.
kosiew
pushed a commit
to kosiew/datafusion
that referenced
this pull request
Aug 12, 2026
## Which issue does this PR close? - Closes None. ## Rationale for this change Follow up to apache#22613 and apache#23253. Cache hits are now supported for all memory-limiting caches. Therefore it makes sense to expose them in the `list_files_cache` function the same way the `metadata_cache` and `statistics_cache` functions do it already. ## What changes are included in this PR? - Add cache hits to the `list_files_cache` function - Tests - Adapt documentation for the `list_files_cache` function ## Are these changes tested? Yes. ## Are there any user-facing changes? Yes, the `list_files_cache` function supports now cache hits but no breaking changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Follow up to #22613. Cache hits are now supported for all memory-limiting caches. Therefore it makes sense to expose them in the
statistics_cachefunction the same way themetadata_cachefunction does it already.What changes are included in this PR?
statistics_cachefunctionstatistics_cachefunctionAre these changes tested?
Yes.
Are there any user-facing changes?
Yes, the
statistics_cachefunction supports now cache hits but no breaking changes.