Repository navigation
fix: preserve dynamic filter identity across FFI - #25624
Closed
tayfuryldz wants to merge 1 commit into
Closed
tayfuryldz wants to merge 1 commit into
tayfuryldz wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the contribution! I am closing this under DataFusion's AI Dump policy. This has the hallmarks of AI code that was not reviewed by the author: a description containing literal escape sequences and a note that clippy was blocked by an unrelated diagnostic, with no engagement since September. If you would like to continue, please open a focused PR in your own words that you have reviewed and understand, and we are happy to help with review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25154. Uses the deduplicating physical proto converter on both sides of the query-planner FFI physical-plan round trip so dynamic-filter expression identity survives serialization. Adds a regression test that crosses the FFI planner boundary, updates one derived dynamic filter, and verifies the other observes the update.\n\nValidation: cargo fmt --all; focused datafusion-ffi regression test passes; focused datafusion-ffi lib clippy passes. Repository-wide all-targets clippy is currently blocked by an unrelated existing unused_async_trait_impl diagnostic in datafusion/datasource-parquet/src/opener/encryption.rs.