Repository navigation
[CI] Refactor CI builders - #8826
Conversation
|
@Jefffrey please review once you have time |
| # Set debuginfo=line-tables-only as debuginfo=0 causes immensely slow build | ||
| # See for more details: https://github.com/rust-lang/rust/issues/119560 | ||
| # | ||
| # set RUST_MIN_STACK to avoid rust stack overflows on tpc-ds tests |
There was a problem hiding this comment.
Maybe put this as a TODO item, since ideally we'd want the tests to pass without needing this setting?
There was a problem hiding this comment.
We still need it as TPC-DS tests spontaneously fail on stack overflow. But we prob need to check why is it happening. That might be a bigger problem with piling up the stackframes.
There was a problem hiding this comment.
I agree it would be great to file a ticket to track the stack overflow
https://github.com/apache/arrow-datafusion/issues?q=is%3Aissue+is%3Aopen+stack+overflow doesn't show any obvious candidate
alamb
left a comment
There was a problem hiding this comment.
I reviewed https://github.com/apache/arrow-datafusion/actions/runs/7491755676/job/20393701106?pr=8826 and all the tests look good to me
Thank you @comphead
| # Set debuginfo=line-tables-only as debuginfo=0 causes immensely slow build | ||
| # See for more details: https://github.com/rust-lang/rust/issues/119560 | ||
| # | ||
| # set RUST_MIN_STACK to avoid rust stack overflows on tpc-ds tests |
There was a problem hiding this comment.
I agree it would be great to file a ticket to track the stack overflow
https://github.com/apache/arrow-datafusion/issues?q=is%3Aissue+is%3Aopen+stack+overflow doesn't show any obvious candidate
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Which issue does this PR close?
Closes #.
Rationale for this change
rust.ymlcontains a lot of duplicates and a little bit overcomplicated, it would be nice to simplify the main CI fileWhat changes are included in this PR?
PR idea is to reduce complexity for
rust.ymland factor out common properties like Rust into a single builder. Separately introduced other builders for each os.Are these changes tested?
Are there any user-facing changes?