Repository navigation
Support Union types in ScalarValue - #9683
Merged
Merged
Conversation
avantgardnerio
marked this pull request as ready for review
March 18, 2024 20:55
thinkharderdev
left a comment
Contributor
There was a problem hiding this comment.
One comment but lgtm
AnalysisContext::try_from_column
thinkharderdev
approved these changes
Mar 19, 2024
AnalysisContext::try_from_columnScalarValue and when building AnalysisContext::try_from_column
ScalarValue and when building AnalysisContext::try_from_columnScalarValue
alamb
approved these changes
Mar 19, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thanks @avantgardnerio
I think this also closes #8500 so added that to the PR description and changed the title to match
6 of 7 tasks
avantgardnerio
added a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Mar 27, 2024
Support Union types in `ScalarValue` (apache#9683) (cherry picked from commit 8074ca1)
avantgardnerio
added a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Mar 27, 2024
avantgardnerio
added a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8499.
Closes #8500
Rationale for this change
It was decided in the linked issue that implementing the variant was the preferred solution.
What changes are included in this PR?
Implement the
ScalarValue::Unionvariant.Are these changes tested?
Via a functional test.
Are there any user-facing changes?
More queries should work.