Repository navigation
Conversation
The release extractor fills github_releases.description_html from description and never reads descriptionHTML, but the collector still asks GitHub for it. Rendering release notes to HTML for a full page of 100 releases can exceed GitHub's GraphQL time limit on repositories with long release notes: the API returns 502/504, the three retries hit the same limit, and Collect Releases fails with "pageInfo is nil". On a repository with 86 releases and ~437 KB of release notes, the current query returned 502 after ~11s; without descriptionHTML the same page of 100 returns in ~2.2s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collect Releasesasks GitHub fordescriptionHTMLon every release, butrelease_extractor.gonever reads it: it fillsDescriptionHTMLfromrelease.Description. Rendering release notes to HTML for a page of 100 releases can exceed GitHub's GraphQL time limit when the notes are long. GitHub then returns 502/504, all three retries hit the same limit, and the subtask fails withfetchPagesDetermined got pageInfo is nil, leaving the pipelineTASK_PARTIAL.This removes the field from the query. Stored data is unchanged, because the extractor already sets the column from
description.Measured on a repository with 86 releases and about 437 KB of release notes, using the collector's exact query at page size 100:
descriptionHTMLdescriptionHTMLDoes this close any open issues?
No existing issue.
Other Information
No new test. The extractor is unchanged, and the github_graphql e2e suite has no release fixtures.
go build,go vetandgo test ./plugins/github_graphql/tasks/...pass.Suggested label:
pr-type/bug-fix(I can't set labels on this repo).