Repository navigation
Conversation
ylwf278
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
November 17, 2026 08:12
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
SbloodyS
requested changes
Nov 17, 2026
SbloodyS
left a comment
Member
There was a problem hiding this comment.
Please follow the pull request notice and template.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17398
Option B from #17398: extend SensitiveDataConverter with masking rules for S3/OSS keys (access-key, secret-key, accessKey, secretKey, accessKeyId, accessKeySecret, access.key.id, access.key.secret, secret.access.key), case-insensitive, covering JSON-like, toString(), and key=value formats. Task instance logs only; both access-key IDs and secret keys are masked.
Tests: added testS3OssAccessKeyLogMsgConverter (17 cases) in SensitiveDataConverterTest. Locally 5/5 pass with the fix, 4/5 without (new test fails, reproducing the issue). Note: full Maven module suite was not run in the sandbox (JVM network blocked); please run mvn -pl dolphinscheduler-task-plugin/dolphinscheduler-task-api -am test in CI.