Skip to content

[Fix-17398][Task-API] Mask S3/OSS access-key and secret-key in task instance logs - #18800

Open
ylwf278 wants to merge 1 commit into
apache:devfrom
ylwf278:issue-17398-mask-s3-oss-keys
Open

ylwf278 wants to merge 1 commit into
apache:devfrom
ylwf278:issue-17398-mask-s3-oss-keys

Conversation

@ylwf278

@ylwf278 ylwf278 commented Nov 17, 2026

Copy link
Copy Markdown

Fixes #17398

Option B from #17398: extend SensitiveDataConverter with masking rules for S3/OSS keys (access-key, secret-key, accessKey, secretKey, accessKeyId, accessKeySecret, access.key.id, access.key.secret, secret.access.key), case-insensitive, covering JSON-like, toString(), and key=value formats. Task instance logs only; both access-key IDs and secret keys are masked.

Tests: added testS3OssAccessKeyLogMsgConverter (17 cases) in SensitiveDataConverterTest. Locally 5/5 pass with the fix, 4/5 without (new test fails, reproducing the issue). Note: full Maven module suite was not run in the sandbox (JVM network blocked); please run mvn -pl dolphinscheduler-task-plugin/dolphinscheduler-task-api -am test in CI.

@boring-cyborg

boring-cyborg Bot commented Nov 17, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@SbloodyS SbloodyS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the pull request notice and template.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][API] Logs support blocking database passwords or sensitive configurations such as S3/OSS access-key and secert-key

2 participants