[FLINK-34099][tests] Harden and disable CheckpointIntervalDuringBacklogITCase - #27630
Merged
Merged
Conversation
Collaborator
rkhachatryan
marked this pull request as ready for review
February 18, 2026 13:18
There are a few issues with both production code and test. Test problems: 1. The test is too short (20 records vs 100 ms checkpoint interval) and has low chances to catch any bugs 2. In fact, a checkpoint IS triggered during backlog; but triggering fails because the 2nd source is slow to startup 3. The 2nd source is slow to start due to busy wait After FLINK-38940, it became more flaky because CheckpointCoordinator now waits for all tasks running. And even more with FLINK-38939, which schedules the checkpoint faster. This change adjusts the test so that it catches bug more reliably.
Contributor
Author
Contributor
|
@flinkbot run azure |
1996fanrui
approved these changes
Feb 18, 2026
1996fanrui
left a comment
Member
There was a problem hiding this comment.
Thanks for reproducing it reliably and ignoring the flaky test to ensure the CI stability, LGTM.
Since this PR does not fix the bug, how about creating a new jira to follow up how to fix the prod bug properly?
Contributor
Author
|
Thanks for the review
I have updated FLINK-34099 ticket to reflect that it's a production code problem. edit: created FLINK-39108 |
…stNoCheckpointDuringBacklog
Contributor
Author
|
Test failure unrelated: Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few issues with both production code and test.
After FLINK-38940, it became more flaky because CheckpointCoordinator now waits for all tasks running.
And even more with FLINK-38939, which schedules the checkpoint faster.
Production code issues:
This change adjusts the test so that it catches bug (1) more reliably.
(Expected) Test failure: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=72468&view=logs&j=5c8e7682-d68f-54d1-16a2-a09310218a49&t=9d734c8c-6253-55e6-3bce-47e7cdf68ac4&l=40053