Repository navigation
[rust] Expose source schema IDs in Arrow batch scans - #4616
Merged
fresh-borzoni merged 2 commits intoOct 30, 2026
Merged
Conversation
Carry the source log batch schema ID through decoding, slicing and the Python and C++ batch bindings. Preserve its identity after projection or schema alignment, and report NO_SCHEMA_ID for batches without a single source schema, including limit scans. Keep existing constructors and expose additive accessors and named sentinels. Cover historical schemas, per-batch metadata and binding conversion, and document the distinction from the output Arrow schema.
loserwang1024
self-requested a review
October 14, 2026 02:52
naivedogger
approved these changes
Oct 16, 2026
naivedogger
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @spoon-lz for this PR. cc @loserwang1024 @fresh-borzoni, any additional thoughts?
fresh-borzoni
approved these changes
Oct 30, 2026
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@spoon-lz Thank you, LGTM 👍
pushed tests and missing docs as well, I'll merge once CI is green
Member
|
@spoon-lz merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: [rust] Expose source schema IDs in Arrow batch scans
Purpose
Fixes #4615
Expose source log batch schema IDs in Arrow scan results, matching the metadata available in the Java client.
Brief change log
NO_SCHEMA_IDin Rust, Python and C++.Tests
Rust workspace tests (855), Python/C++ binding conversion tests, Clippy, Rustdoc and formatting checks passed. Rust integration tests compiled; live-cluster tests were not run. Full C++ integration-test compilation was blocked by missing
nlohmann/json.hpp.API and Format
Additive metadata accessors; no protocol or storage-format changes. C++ bindings and clients need to be rebuilt together.
Documentation
Updated API reference tables and interface comments.
Generative AI disclosure
Yes — OpenAI Codex was used to prepare the implementation, tests, and validation materials.