Repository navigation
[2.4.x] Backport mod_env SetEnvFromFile - #934
Open
cisbiceanu wants to merge 1 commit into
Open
cisbiceanu wants to merge 1 commit into
cisbiceanu wants to merge 1 commit into
Conversation
Backport trunk commit 837965f (r1938506). Include the stable-branch documentation, changelog, and test availability marker for 2.4.70. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes backporting the
SetEnvFromFiledirective from trunk to the stable2.4.xbranch.The implementation was accepted in 837965fd1e (r1938506), following discussion in #750.
Motivation
SetEnvFromFileallows administrators to populate httpd’s internal environment from a file ofname=valueentries, read at configuration time. This keeps variable values separate from the main configuration while preserving the behavior ofSetEnvfor CGI, SSI, and other consumers.Changes
mod_envimplementation without functional changes.As in trunk, the directive is not permitted in
.htaccess, to prevent untrusted configuration authors from exposing files readable by the server.Validation
Built and tested locally on macOS against Apache 2.4.70-dev. All four directive regression tests passed: file parsing, malformed-line handling,
.htaccessrejection, and missing-file configuration failure. Documentation DTD validation also passed.The release number is provisional and can be adjusted to the version selected for the backport. The corresponding
backported_intest marker should also be mirrored to trunk when the backport is accepted.