Repository navigation
chore: upgrade OINK to 1.3.1 - #539
Conversation
- replace local readability patches with native components - reconcile navigation, print and archived table assembly - reuse verified compilers and protect upgrade artifacts - document native authoring and expand browser regressions
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: Removing the site-wide table rule leaves the latest HugeGraph-Computer configuration reference without the .td-table--wide marker that this PR gives every other configuration catalogue (including the archived config-computer.md), so its option names go back to breaking mid-token. Evidence: static review of the exact head effae1d against base dd0693f; git grep over content/ at the head; OINK v1.3.1 module source (assets/scss/td/_content.scss lines 9 and 197-224, assets/scss/td/_brand.scss lines 232-236); the PR's new tests/e2e/pd-table.spec.js route list. Latest-head CI: prepare and the three build groups pass; the deploy job (aggregate and Chromium contracts) was still running at review time.
- opt current reference catalogs into native widths - adapt frozen catalogs through audited assembly rules - preserve indented examples and ordinary table layouts - bind browser checks to catalogs and extend captures
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The Computer catalogue gap raised on effae1d is fixed at this head. One upgrade gap remains: the shell/config.html override was not reconciled with OINK v1.3.1, so Expo albums written by the new contribution guide would lose the shell script, local search and the mobile docs drawer. Evidence: static review of f42c5d4 against dd0693f. I diffed every upstream-changed site override against OINK v1.2.0 and v1.3.1. I also checked the Sass archive checksum against the release digest and confirmed that every Computer table in both languages has {.td-table--wide}. Not built locally, because Hugo 0.168 and Dart Sass are not installed here. Latest-head CI: prepare, the three build groups and deploy (aggregate and Chromium contracts) pass; the advisory visual job is queued.
- reconcile shell defaults and empty quick links with OINK 1.3.1 - mount bilingual Expo fixtures only in the AI browser artifact - verify native search, mobile navigation and viewer controls - keep sample albums out of production and disabled-AI builds
imbajin
left a comment
There was a problem hiding this comment.
Independent cross/adversarial review: 8.5/10 at this revision. No confirmed new blocking finding within the reviewed scope.
Both earlier findings are addressed: Computer tables now use the native wide-table markers in both languages with readability/keyboard-scroll test coverage; the Expo shell preserves the upstream default types and explicitly empty quick links, with bilingual interaction fixtures and a production-absence check. Print/navbar overrides incorporate the relevant upstream changes while retaining the project's publication/branding behavior. All 74 changed sources and the Markdown diff were inspected; the content adjustments add native table/wrapping markers without removing prose or table data.
The upgrade runner validates a real Sass compile before lock mutation, preserves the original backup and reviewed baseline, and confines historical adaptations to known versions/paths/headers in temporary assembly. Compiler versions and setup code participate in artifact/cache fingerprints. Publish write permission remains isolated and PR publication is skipped.
Independent bounded cloud checks passed: 18 workflow-contract tests, plus 45 upgrade/inventory/cache tests. Five compiler-dependent cases were skipped because Hugo/Sass are unavailable locally; one network-dependent Go-download case was deliberately omitted. These are distinct from exact-head CI, which succeeded.
No local full Hugo/Sass build, independent browser/screenshot comparison, or exhaustive compatibility claim is made. Visual CI captures are not proof of pixel parity. With those limits, this is a reasonable merge candidate; no duplicate inline comments are needed for the repaired findings.
- remove the redundant navbar item template override - update the reviewed override inventory after validation - preserve the source guard when a local override exists
- preserve updated bilingual Arthas guidance - retain native wide tables on current content - align HStore assertions with removed table
master (apache#539) adds {.td-table--wide} after the Docker env tables, right where this branch appends the HG_STORE_ROCKSDB_TOTAL_MEMORY_SIZE row. Keep the new row as the table's last row, followed by the attribute.
Purpose of the PR
Upgrade the site from OINK 1.2.0 to 1.3.1 and replace the local readability patches with upstream behavior. FileTree uses
wrap=true; technical configuration tables use.td-table--wide; Markmap colours and footer clearance come from the theme. HugeGraph branding, the Slate default and the Paper/Slate reader menu are preserved.The upgrade runner now checks the target toolchain with a real Dart Sass compile before changing locks, protects baseline captures and backups, and reuses the bounded historical builder. CI shares a verified Hugo/Sass setup and includes Sass in artifact fingerprints. The navbar, shell configuration and Print integrations absorb upstream fixes, including native Expo navigation and explicitly empty quick links. A redundant navbar-item override is removed so menu items inherit the theme directly. Current configuration, field, API and CLI catalogues opt in explicitly; ordinary explanation tables retain the default layout. Frozen references receive the same native markers through audited paths and headers in the existing temporary assembly; release sources stay pinned.
AGENTS.md and the contribution guide explain when to use OINK's native components, including Gallery versus Expo, without adding an album or redesigning the homepage. A bilingual test-only Expo fixture checks native search, mobile navigation and the image viewer without publishing sample content.
Validation: warning-strict build; all historical versions and aggregate links/output validation; Python source contracts; Chromium navigation, search, accessibility, native components and AI consent/on/off contracts.
Screenshots compare 1.2.0 with site patches against 1.3.1 with native implementations, using the same browser, viewport and appearance settings.
The native PD table keeps configuration names and descriptions readable within a smaller scroll range. FileTree wrapping, dark Markmap contrast and TOC/footer clearance retain the required behavior after removing the corresponding local patches. The complete paired matrix also covers the homepage, provider API matrices, both reader styles, languages, viewports and footer states; local captures and reports are preserved, and CI uploads its browser reports and visual captures as artifacts.