Repository navigation
Enhance summary info - #80
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
============================================
+ Coverage 65.3% 65.82% +0.51%
- Complexity 320 324 +4
============================================
Files 46 46
Lines 1542 1583 +41
Branches 182 184 +2
============================================
+ Hits 1007 1042 +35
- Misses 430 433 +3
- Partials 105 108 +3
Continue to review full report at Codecov.
|
Contributor
|
split into two commits, one is summary info, another is http-connection |
imbajin
force-pushed
the
enhance-summary-info
branch
from
June 18, 2019 09:16
43e2581 to
d2cb447
Compare
javeme
requested changes
Jun 19, 2019
| try { | ||
| Vertex vertex = builder.next(); | ||
| batch.add(vertex); | ||
| this.parseSuccessPerSource++; |
Contributor
There was a problem hiding this comment.
prefer to let loadVertex() return parseSuccessPerSource, and don't define parseSuccessPerSource as field
Linary
requested changes
Jun 19, 2019
| LoadSummary summary = new LoadSummary("vertices"); | ||
| Duration duration = Duration.between(beginTime, endTime); | ||
| summary.parseFailure(this.parseFailureNum); | ||
| summary.parserSuccess(this.parseSuccessNum); |
Contributor
There was a problem hiding this comment.
parserSuccess -> parseSuccess
1. add parserSuccess to comfirm data integrity 2. add parserSpeed to get performance results directly 3. record the import speed of each data source in the log for comparison
imbajin
force-pushed
the
enhance-summary-info
branch
from
June 19, 2019 16:49
b95c796 to
cd31348
Compare
Linary
approved these changes
Jun 20, 2019
javeme
approved these changes
Jun 20, 2019
imbajin
pushed a commit
that referenced
this pull request
Apr 14, 2022
Change-Id: I29cb85a9e1d306afb49c050aab0c0d3a77fdd70d
imbajin
pushed a commit
that referenced
this pull request
Apr 14, 2022
Change-Id: I1ae7e37f1c94e17860fb0247ebb58cd8359d004d
This was referenced Oct 22, 2026
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.