Repository navigation
fix(tools): propagate restore worker failures - #803
Merged
Merged
Conversation
- drain asynchronous tasks before reporting failures - preserve suppressed errors and interrupt state - retain backup input when restore fails - cover corrupt input and valid empty backups
imbajin
marked this pull request as ready for review
October 10, 2026 06:00
MrJs133
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
A restore worker could fail while reading a damaged JSON/ZIP file or inserting records, yet the command would report success and clean its input directory. Worker failures now reach the existing CLI error path after all submitted work finishes, and failed restores retain their inputs.
Found in the Toolchain integration report.
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need: restores the existing CLI failure and cleanup contract.Organization and upstream core CI pass. Original and fixed native packages use the same verified Server SDK and fixture; task-owned graphs and services are cleaned up after acceptance.
The native CLI checks answer
nto its existing optional stack-trace prompt before verifying the Unix error exit; this PR preserves that prompt contract.