Repository navigation
fix(loader): warn for legacy file options - #809
Merged
imbajin merged 1 commit intoOct 12, 2026
Merged
Conversation
- record deprecated aliases during option validation - retain positive checks and post-validation warnings - cover direct and file inputs with help and errors - document argument-file warning behavior
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #809 +/- ##
=========================================
Coverage 44.75% 44.76%
Complexity 3323 3323
=========================================
Files 377 377
Lines 22484 22488 +4
Branches 3005 3006 +1
=========================================
+ Hits 10062 10066 +4
Misses 11351 11351
Partials 1071 1071 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pengzna
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
--parallel-countinside an argument file parsed correctly but missed the deprecation warning because the check only inspected the original command line. Track the actual option name during JCommander validation so direct and argument-file inputs both warn once after successful validation.--parser-threadsremains silent. Positive-number checks, help and invalid-input behavior are preserved, and the Loader README explains the warning. This uses the existing parser without adding argument-file expansion or dependencies.Validation: the argument-file regression fails before the fix and passes afterward; focused Maven option tests, EditorConfig, Checkstyle and three independent reviews passed. Related release-validation issue: TC21.
Change diagram
Warn once for the legacy Loader option after successful direct or response-file validation. This conceptual diagram does not replace the validation and scope notes above.
