Skip to content

fix(hubble): collect graph snapshots and explain unavailable results - #862

Merged
imbajin merged 9 commits into
apache:masterfrom
hugegraph:fix/hubble-vermeer-result-feedback
Oct 29, 2026
Merged

imbajin merged 9 commits into
apache:masterfrom
hugegraph:fix/hubble-vermeer-result-feedback

Conversation

@imbajin

@imbajin imbajin commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Before → After

Before: Graph-card counts have no collection action, and unavailable native Vermeer values can appear as generic errors despite successful task completion.

After: Add bounded count collection and an administrator-authorized loaded-graph snapshot read, with source/timestamp attribution. Distinguish exact task-scoped missing values from authorization, task mismatch and transient failures, and retain inline retry guidance without changing the task status.

Validation boundary

The author reports 26 backend and 97 targeted frontend tests plus controlled Chromium checks. These do not establish live deployment counts or algorithm correctness. The additive snapshot read is capability-gated and does not trigger a full Server scan or graph reload.

Source PR: 🔗 hugegraph/hugegraph-toolchain #111

Visual overview

Vermeer result-read diagnostic and retry

Controlled-API Chromium screenshot of an inline result-read diagnostic with graph/task context and retry, separate from computation status. This illustrates error presentation, not live task execution, result retention, count correctness or current-head retry-source validation.

@bitflicker64 bitflicker64 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: yes. Summary: the Vermeer snapshot endpoint, task-scoped absence matching and the inline result-read diagnostics hold up, but the new result-read copy fails src/i18n/ui-copy-punctuation.test.js, so pnpm test:ci is red at this head.

MrJs133
MrJs133 previously approved these changes Oct 29, 2026
MrJs133
MrJs133 previously approved these changes Oct 29, 2026
MrJs133
MrJs133 previously approved these changes Oct 29, 2026
@imbajin
imbajin merged commit 69b52d2 into apache:master Oct 29, 2026
16 checks passed
@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.07%. Comparing base (b34007e) to head (236e021).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...apache/hugegraph/service/space/VermeerService.java 60.00% 2 Missing ⚠️
.../hugegraph/controller/graphs/GraphsController.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #862      +/-   ##
============================================
- Coverage     55.40%   54.07%   -1.33%     
+ Complexity     5989     3503    -2486     
============================================
  Files           619      282     -337     
  Lines         32582    19300   -13282     
  Branches       4217     2910    -1307     
============================================
- Hits          18052    10437    -7615     
+ Misses        12952     7762    -5190     
+ Partials       1578     1101     -477     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants