Skip to content

fix(hubble): clarify import progress and demo guidance - #877

Merged
imbajin merged 10 commits into
apache:masterfrom
hugegraph:codex/hubble-import-guidance
Oct 31, 2026
Merged

imbajin merged 10 commits into
apache:masterfrom
hugegraph:codex/hubble-import-guidance

Conversation

@imbajin

@imbajin imbajin commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Before

Demo guidance is cramped, and Loader input offsets are labeled as successful imports.

After

Wrap Demo actions below guidance and label progress as input reads, including headers, skipped and failed rows; do not claim successful-write counts.

Validation and scope

Author-reported validation is recorded in the source PR; independent dots review and exact-head ASF CI are pending. No live deployment or RC acceptance is claimed.

Source review: hugegraph/hugegraph-toolchain#114. This PR uses the same source branch; see that discussion for detailed validation evidence and limitations.

Visual overview

读取输入口径可能包含表头、跳过及失败输入,不等同成功写入量;图中数字仅为示例。 机制示意;不表示独立实测、CI 或同一 RC 已通过。评审核对:2026-10-31。

机制示意

@codecov

codecov Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.54%. Comparing base (b34007e) to head (56fc6e8).
⚠️ Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
.../hugegraph/controller/ingest/IngestController.java 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #877      +/-   ##
============================================
+ Coverage     55.40%   55.54%   +0.14%     
+ Complexity     5989     3735    -2254     
============================================
  Files           619      285     -334     
  Lines         32582    19926   -12656     
  Branches       4217     3043    -1174     
============================================
- Hits          18052    11068    -6984     
+ Misses        12952     7675    -5277     
+ Partials       1578     1183     -395     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bitflicker64 bitflicker64 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: no. Score: 9/10. Summary: Task history separates input reads from per-attempt confirmed_vertex_writes and confirmed_edge_writes taken from the Loader summary, the idempotent ALTER TABLE leaves historical rows unknown, and datasourceCreate records the session user instead of a submitted creator; the new backend, Jest and UI regression checks pass on this head.

MrJs133
MrJs133 previously approved these changes Oct 31, 2026
@imbajin
imbajin merged commit 77b31c1 into apache:master Oct 31, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants