Repository navigation
fix: preserve task and query failure causes - #3394
Merged
Merged
Conversation
- fail interrupted submissions and allocate unique job IDs - report exhausted PD calls with their original causes - propagate sort failures and close conversion iterators - cover retry and cleanup contracts with regression tests
4 of 11 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3394 +/- ##
============================================
+ Coverage 55.93% 56.90% +0.96%
- Complexity 2277 2728 +451
============================================
Files 774 776 +2
Lines 68534 68901 +367
Branches 9333 9425 +92
============================================
+ Hits 38334 39205 +871
+ Misses 26634 26081 -553
- Partials 3566 3615 +49
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
imbajin
force-pushed
the
fix/java17-cleanup-round2
branch
from
October 22, 2026 20:23
ceb2b91 to
e7b0405
Compare
imbajin
marked this pull request as ready for review
October 22, 2026 20:24
MrJs133
approved these changes
Oct 22, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Counterpart: hugegraph#330. Both PRs use the same source branch.
Builds on the lifecycle cleanup merged in ASF #3393. This diff contains the second cleanup round only.
Keep task and query failures visible to callers, while preserving existing API signatures, retry budgets, negative task-ID rules and stored data formats.
Main Changes
Also retain causes when wrapping checked task errors and preserve scheduler failures without exception messages. Type conversion keeps stable iterator probes, direct
next()calls and completion-supplier retry behavior.Verifying these changes
Validated with Java 17: repository formatting and full clean compile, followed by focused Server, PD and Store tests against the updated artifacts. Independent review found no remaining blocking issue. Multi-node cluster validation is not included.
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO: required documentation is pending; complete it before merging.Doc - Done: documentation is included here.Doc - No Need: no user-visible documentation is affected.Documentation: storage lifecycle contracts. No website configuration or API-reference changes are required.
Visual overview
Failure propagation across interrupted submission, atomic task IDs, exhausted PD retries and owned iterator cleanup. Conceptual illustration; existing retry and compatibility contracts remain, and no cluster or RC acceptance is implied.