Repository navigation
fix(store): provide compact Raft metrics for dashboard collection - #3433
Merged
Merged
Conversation
Add a constant-size summary for dashboard collection.\nKeep detailed registries on the existing endpoint.\nTest empty, disabled and 1000-group responses and document the contract.
This was referenced Oct 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3433 +/- ##
============================================
+ Coverage 57.27% 57.70% +0.43%
+ Complexity 6577 2586 -3991
============================================
Files 776 779 +3
Lines 68881 69150 +269
Branches 9431 9502 +71
============================================
+ Hits 39449 39901 +452
+ Misses 25804 25583 -221
- Partials 3628 3666 +38
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bitflicker64
approved these changes
Oct 29, 2026
bitflicker64
left a comment
Contributor
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: GET /metrics/raft/summary returns two counts from the same HgStoreEngine.getNodeMetrics() map that /metrics/raft serializes, handles null NodeMetrics entries, and leaves the detailed endpoint unchanged. HgStoreMetricsControllerTest (4 tests) passes in the pd_store / store job at this head, and all other checks are green or skipped.
MrJs133
approved these changes
Oct 29, 2026
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before → After
Before: Detailed Raft metrics serialize per-group registries and can exceed Hubble's collection limit.
After: Add a compact Raft summary endpoint exposing group and enabled-metrics counts while retaining detailed diagnostics and existing access controls.
Validation boundary
The author reports four controller tests and a 16-module compile. Counts describe metrics collection, not group health; no independent deployment or load acceptance is claimed. Paired with hugegraph/hugegraph-toolchain#110.
Source PR: 🔗 hugegraph/hugegraph #355
Visual overview
Design illustration: the additive summary endpoint returns group and metrics-enabled counts without serializing per-group registries. Values shown are illustrative; enabled metrics do not establish Raft health. The detailed endpoint remains available. No CI, cluster or performance acceptance is claimed.