Skip to content

Fix consumer group response handling in topic procedures - #19047

Merged
JackieTien97 merged 1 commit into
masterfrom
fix/topic-consumer-group-response-statuses
Oct 29, 2026
Merged

JackieTien97 merged 1 commit into
masterfrom
fix/topic-consumer-group-response-statuses

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

AlterTopicProcedure and DropTopicProcedure still expect a List<TSStatus> from pushSingleConsumerGroupOnDataNode after that API changed to return Map<Integer, TPushConsumerGroupMetaResp>, which breaks ConfigNode compilation at four call sites.

Extract each response status in both forward and rollback paths before the existing status checks, following the handling already used by AlterConsumerGroupProcedure.

Validation:

  • mvn spotless:apply -P with-integration-tests -pl iotdb-core/confignode
  • git diff --check

Full compilation and unit tests were not run for this narrow API adaptation.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.98%. Comparing base (d452ddd) to head (b7d3010).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...e/impl/subscription/topic/AlterTopicProcedure.java 0.00% 6 Missing ⚠️
...re/impl/subscription/topic/DropTopicProcedure.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #19047      +/-   ##
============================================
- Coverage     48.04%   47.98%   -0.07%     
  Complexity      604      604              
============================================
  Files          5570     5571       +1     
  Lines        409051   409682     +631     
  Branches      53848    54009     +161     
============================================
+ Hits         196512   196567      +55     
- Misses       212539   213115     +576     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JackieTien97
JackieTien97 merged commit 2d047dc into master Oct 29, 2026
39 of 42 checks passed
@jt2594838
jt2594838 deleted the fix/topic-consumer-group-response-statuses branch October 29, 2026 06:20
VGalaxies pushed a commit to VGalaxies/iotdb that referenced this pull request Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants