Repository navigation
Fix consumer group response handling in topic procedures - #19047
Merged
Merged
Conversation
jt2594838
approved these changes
Oct 29, 2026
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19047 +/- ##
============================================
- Coverage 48.04% 47.98% -0.07%
Complexity 604 604
============================================
Files 5570 5571 +1
Lines 409051 409682 +631
Branches 53848 54009 +161
============================================
+ Hits 196512 196567 +55
- Misses 212539 213115 +576 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




AlterTopicProcedure and DropTopicProcedure still expect a
List<TSStatus>frompushSingleConsumerGroupOnDataNodeafter that API changed to returnMap<Integer, TPushConsumerGroupMetaResp>, which breaks ConfigNode compilation at four call sites.Extract each response status in both forward and rollback paths before the existing status checks, following the handling already used by
AlterConsumerGroupProcedure.Validation:
mvn spotless:apply -P with-integration-tests -pl iotdb-core/confignodegit diff --checkFull compilation and unit tests were not run for this narrow API adaptation.