Avoid null-pointer failure before EAR execution context setup - #563
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Report an actionable Maven failure when a configured EAR module attempts artifact resolution before its execution context is initialized. Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configured EAR modules can attempt artifact resolution before their execution context is initialized. That currently produces an opaque
NullPointerExceptionwhen the module accesses the artifact repository.This adds an explicit
MojoFailureExceptionwith the module identity and a regression test for the uninitialized-context path.Fixes #514
Testing
mvn -DskipITs -Dspotless.check.skip=true -Dspotless.apply.skip=true test— passed (49 tests).NullPointerExceptionand passed with this change.git diff --check— passed.NoSuchFieldErrorincom.sun.tools.javac.tree).Notes
This contribution was developed with AI assistance. I reviewed the complete diff and verified the failure before and after the fix. No competing open PR for #514 was found.