Skip to content

NIFI-16486 Showed full Controller Service names in combo editor - #11909

Open
anshuksi282-ksolves wants to merge 1 commit into
apache:mainfrom
anshuksi282-ksolves:nifi-16486
Open

anshuksi282-ksolves wants to merge 1 commit into
apache:mainfrom
anshuksi282-ksolves:nifi-16486

Conversation

@anshuksi282-ksolves

Copy link
Copy Markdown
Contributor

Summary

NIFI-16486

In the property table, the combo editor for properties with allowable values (for example the Database Connection Pooling Service of ExecuteSQL) opens with the width of the value cell. Long Controller Service names are cut off with an ellipsis and there is no way to seethe full name for values without a description.

This change:

  • sets the title of allowable values without a description to their display name, so the full name is shown on hover (values with a description already show the description as a tooltip)
  • gives the combo editor a minimum width of 500px, so fewer names are cut off when the value cell is narrow; wider cells keep the existing width + 50

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Verified with nx build nifi, nx lint nifi, Prettier, and the combo-editor and property-table specs (new tests for the option title and the editor width). Checked in a running NiFi (ExecuteSQL > Database Connection Pooling Service): the editor opens at 500px and hovering an option shows the full Controller Service name.

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

No new dependencies were added.

Documentation

  • Documentation formatting appears as expected in rendered files

No documentation files were changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant