Repository navigation
NIFI-5318 Implement NiFi test harness - #3165
peter-gergely-horvath wants to merge 6 commits into
Conversation
|
Hi @MikeThomsen I have opened this new pull request instead of #2872 according your suggestions. Here we have everything sorted out you mentioned earlier on. Now the build executes the test cases if you specify |
|
Will try to get back into it soon. BTW, thanks for putting it all back onto a branch. |
| @@ -0,0 +1,28 @@ | |||
|
|
|||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
this xml document looks like a real http response. We cannot use it as test material unless we can assert its license and it is ALv2 compatible. Its better to use entirely synthetic test data.
There was a problem hiding this comment.
Yes, it absolutely must be changed because the BBC is asserting its IP rights here:
<copyright><![CDATA[Copyright: (C) British Broadcasting Corporation, see http://news.bbc.co.uk/2/hi/help/rss/4498287.stm for terms and conditions of reuse.]]></copyright>
MikeThomsen
left a comment
There was a problem hiding this comment.
@peter-gergely-horvath the sample infringes on BBC IP, so it should be changed ASAP.
| @@ -0,0 +1,28 @@ | |||
|
|
|||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Yes, it absolutely must be changed because the BBC is asserting its IP rights here:
<copyright><![CDATA[Copyright: (C) British Broadcasting Corporation, see http://news.bbc.co.uk/2/hi/help/rss/4498287.stm for terms and conditions of reuse.]]></copyright>
…payload with synthetic content
|
Hi Guys, thank you for pointing this out. I've replaced it with some synthetic content. |
|
@peter-gergely-horvath Tried your latest change and still get these results: |
…ssue; better reporting of paths
|
@MikeThomsen this issue has now been fixed. Please review / try it again: now it works properly. |
|
@peter-gergely-horvath confirmed that it worked. I'll need to spend some time looking at it again and trying to write my own tests as a POC to verify it works outside of the supplied tests. Thanks for keeping up with this. |
…i version can be queried
|
Brilliant, let me know if you need any help / have questions. I have added tiny bit of fix there in the meanwhile -- should not affect anything. |
|
Any ideas? Got this after rerunning: |
|
You should be able to fish out the failed test's output from the following files:
Maybe that helps. If not, please post their content to here. |
…to setClassOfSingleProcessor to prevent configuring obviously incorrect classes
|
@joewitt, @MikeThomsen I am wondering if it would be possible to make some progress with this PR? (I understand you might be very busy) Based on best of my knowledge, this feature (and code base) works properly: I absolutely appreciate the dedication of ensuring that only quality code should become part of NiFi, but at the same time I think releasing something that might later be improved is part of the natural evolution:
I had some previous projects where having a (even a primitive) NiFi test harness would have been of a huge relief. Please let me know if I can help you in any way here. |
|
@peter-gergely-horvath been busy w/ the day job and building out our new graph database bundle, but yeah I'm trying to circle back to this. I'll start kicking the tires again soon. |
|
@peter-gergely-horvath I tried my own simple test with five steps that ended with PutMongo, and it crashed hard. Here are the logs: org.apache.nifi.testharness.samples.NiFiMongoTest-output.txt |
| } | ||
|
|
||
| private void installFlowFile(File fileToIncludeInGz) throws IOException { | ||
| Zip.gzipFile(fileToIncludeInGz, flowXmlGz); |
There was a problem hiding this comment.
NM, documentation problem! (Or lack thereof)
|
@peter-gergely-horvath I was able to get a test flow working. We'll need to work on some documentation and some cleanup soon. I think this is pretty close to being ready to merge as a MVP with the caveat that it is for advanced NiFi users that aren't afraid to sling a lot of Java code. |
NIFI-5318 Implement NiFi test harness: replaced original sample feed payload with synthetic content NIFI-5318 Implement NiFi test harness: fixed test harness run crash issue; better reporting of paths NIFI-5318 Implement NiFi test harness: added further states where NiFi version can be queried NIFI-5318 Implement NiFi test harness: fixed incorrect class reference NIFI-5318 Implement NiFi test harness: added type parameter bounding to setClassOfSingleProcessor to prevent configuring obviously incorrect classes NIFI-5318 Updated project version. This closes apache#3165 Signed-off-by: Mike Thomsen <mikerthomsen@gmail.com>
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.