Repository navigation
Conversation
607958b to
a2cdc1a
Compare
|
@dongjoon-hyun @deshanxiao Could you please take a look? Thanks! |
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| sources: |
There was a problem hiding this comment.
Do we need to maintain this in Apache ORC repository?
|
|
||
| required_conan_version = ">=1.54.0" | ||
|
|
||
| class OrcRecipe(ConanFile): |
There was a problem hiding this comment.
Thank you for this proposal, @wgtmac . I have two questions.
- Are you going to publish all live releases (1.9/1.8/1.7) in this way? I prefer to do this at Apache ORC 2.0 only.
- I'm curious if this is a standard way to maintain Conan stuff (version list, receipt, package test code). It looks quite different from Homebrew or vcpkg ways.
|
@dongjoon-hyun Thanks for the feedback! Please see my comment below.
I have only added the latest version of each live release in case people want to stay on an older version.
The standard way to maintain conan recipe is to put them in the conan-center-index:
Apache Arrow has also put a copy of that from conan-center-index with a slight modification: https://github.com/apache/arrow/tree/main/ci/conan/all. This is used in the release process and also facilitate users to customize their own conan recipe or use an unofficial version (e.g. current main branch). I will upstream these to the conan-center-index and keep them in sync. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, it sounds like a great plan. Thank you, @wgtmac .
|
Thank you @wgtmac. +1 LGTM. Do you have plan to add document make-release.md in this PR? |
Thanks for the suggestion! I will update it once this gets merged in the conan-center-index. |
|
I just merged this. Thanks @dongjoon-hyun and @deshanxiao. I will upstream this to the conan community. |
|
Please cherry-pick this to branch-2.0 too, @wgtmac . |
### What changes were proposed in this pull request? Add conan recipe for the C++ library. The latest release of supported versions are added by default. ### Why are the changes needed? Conan is a popular C++ package manager: https://docs.conan.io/2/index.html. It would be good to support conan recipe on our end. ### How was this patch tested? Test it locally using conan command. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#1805 from wgtmac/conan. Authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: Gang Wu <ustcwg@gmail.com>
What changes were proposed in this pull request?
Add conan recipe for the C++ library. The latest release of supported versions are added by default.
Why are the changes needed?
Conan is a popular C++ package manager: https://docs.conan.io/2/index.html. It would be good to support conan recipe on our end.
How was this patch tested?
Test it locally using conan command.
Was this patch authored or co-authored using generative AI tooling?
No