Repository navigation
[flink] Keep NOT NULL of VARIANT columns created through Flink - #10617
Merged
Merged
Conversation
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
close #10616
LogicalTypeToDataType.visit(VariantType)always created a nullable PaimonVariantType, so aVARIANT NOT NULLcolumn created through Flink was stored as nullable and NULLs could be written into it. It now keeps the nullability of the Flink type, like the other types in the converter.Tests
CatalogTableITCase#testVariantNotNull(Flink 2.1 and above): inserting NULL into aVARIANT NOT NULLcolumn fails on the NOT NULL constraint, nothing is written, and the stored column is not nullable. On master the insert succeeds.API and Format
no
Documentation
no