Skip to content

Enable Solr Operator metrics when using the helm chart. - #360

Merged
HoustonPutman merged 3 commits into
apache:mainfrom
HoustonPutman:helm-metrics
Nov 2, 2021
Merged

HoustonPutman merged 3 commits into
apache:mainfrom
HoustonPutman:helm-metrics

Conversation

@HoustonPutman

Copy link
Copy Markdown
Contributor

Resolves #307

This does not use the protected metrics-endpoint described in the kubebuilder docs. This is also just using the default operator metrics. We can add additional metrics in future PRs.

The metrics have been enabled since #321 was implemented, but not when using the helm chart. This fixes that.

@HoustonPutman
HoustonPutman requested a review from janhoy October 29, 2021 19:48

@janhoy janhoy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not tested

@HoustonPutman

Copy link
Copy Markdown
Contributor Author

Tested manually and was able to query the operator metrics through kubectl port-forward.

@HoustonPutman
HoustonPutman merged commit 8732003 into apache:main Nov 2, 2021
@HoustonPutman
HoustonPutman deleted the helm-metrics branch November 2, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose operator metrics

2 participants