Repository navigation
fix(deps, frontend): deduplicate Angular toolchain under @angular-builders/custom-webpack - #8127
Merged
aglinxinyuan merged 3 commits intoSep 17, 2026
Conversation
…lders/custom-webpack @angular-builders/custom-webpack@21.1.0 declares a loose dep on @angular-devkit/build-angular@^21.0.0. Yarn was resolving that range to 21.2.18, creating a nested copy under the builder's own node_modules/ while the pinned 21.2.19 sat at the workspace root. Because angular.json routes both build and serve through @angular-builders/custom-webpack, the older toolchain (21.2.18) was the one actually compiling the app. Fix: add Yarn resolutions for @angular-devkit/build-angular, @angular/build, and @ngtools/webpack pinned to 21.2.19, mirroring the existing devDependencies pins. This collapses the three duplicate lockfile entries (276 lines removed) and ensures the installed toolchain matches the pinned version. Closes apache#8052
Contributor
Backport auto-label reportThis
|
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8127 +/- ##
============================================
+ Coverage 92.94% 92.96% +0.01%
- Complexity 4883 4885 +2
============================================
Files 1232 1232
Lines 51628 51628
Branches 6354 6354
============================================
+ Hits 47988 47994 +6
+ Misses 2076 2073 -3
+ Partials 1564 1561 -3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xuang7
removed their request for review
September 13, 2026 23:06
Contributor
|
@xuang7 and @aglinxinyuan, please fix the CI (rerun it on GitHub UI). It seems related to the time the release label was removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Adds three Yarn
resolutionsentries tofrontend/package.jsonto force@angular-builders/custom-webpack's transitive dependencies to the same versionsalready pinned in
devDependencies:@angular-devkit/build-angular→21.2.19@angular/build→21.2.19@ngtools/webpack→21.2.19@angular-builders/custom-webpack@21.1.0declares a loose dep on@angular-devkit/build-angular: ^21.0.0, which Yarn was resolving to21.2.18.This created a nested copy of the toolchain under the builder's own
node_modules/while the pinned
21.2.19sat unused at the workspace root. Becauseangular.jsonroutes both
buildandservethrough@angular-builders/custom-webpack, theolder toolchain (
21.2.18) was the one actually compiling the app and running thedev server — silently, with CI staying green. The same split affected
@angular/buildand
@ngtools/webpack.The
resolutionsfield was already in use infrontend/package.jsonformonaco-editor,webpack, andjschardet; this PR follows the same pattern.Result: 276 lines removed from
yarn.lock; all three packages now have a singlelockfile entry at
21.2.19; the nested@angular-builders/custom-webpack/node_modules/@angular-devkit/copy is gone.No production source code files were modified.
Any related issues, documentation, discussions?
Closes #8052
How was this PR tested?
Verified the lockfile and installed tree after running
yarn installinsidefrontend/:Was this PR authored or co-authored using generative AI tooling?
No