Repository navigation
feat(gui): read the schema's constraints in the property panel - #8507
Merged
aglinxinyuan merged 2 commits intoSep 24, 2026
Merged
Conversation
A column property is checked against the attribute type rule for every column it names rather than only the first. A hyperparameter's value renders as the control its parameter implies: a dropdown where the accepted set is known, a number input where it is numeric, a plain text box where the rules say nothing. A property declared unique among rows says which row already holds the value, and a row deleted clears the error it left behind. Split out of apache#8350 on review. That change is the export button; this one is a separate thread, and nothing in it makes a workflow exportable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8507 +/- ##
============================================
- Coverage 92.73% 92.72% -0.02%
Complexity 4926 4926
============================================
Files 1241 1242 +1
Lines 52476 52564 +88
Branches 6475 6505 +30
============================================
+ Hits 48662 48738 +76
- Misses 2206 2210 +4
- Partials 1608 1616 +8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
13 of 31 tasks
Contributor
Author
|
/request-review @aglinxinyuan |
carloea2
approved these changes
Sep 18, 2026
carloea2
left a comment
Contributor
There was a problem hiding this comment.
The schema rules and row revalidation look good.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
aglinxinyuan
enabled auto-merge
September 24, 2026 22:43
renovate-bot
pushed a commit
to renovate-bot/apache-_-texera
that referenced
this pull request
Oct 15, 2026
…ints in the panel (apache#8350) ### What changes were proposed in this PR? The browser side of the export. A button on the workflow toolbar asks the compiling service to translate the canvas into a Python script and shows what comes back, with a copy control so the script can be taken somewhere that runs it. The translation is a round trip, so the button disables itself while one is in flight, and a workflow the translator cannot express comes back with a reason rather than an empty modal. The route is added in the two places a browser reaches the compiling service from: the dev server's proxy and the single-node nginx. A workflow that fails to compile cannot be executed either, so the run button reads the compilation state alongside the schema and port validation it already read. Running to one operator is offered only when everything upstream of it compiled too, not only the operator itself. ### Any related issues, documentation, discussions? Part of apache#8325, 25 of 27; that issue lists the set in order. The property panel's reading of the schema's constraints is in apache#8507. This one stands alone. It touches no Scala, so it compiles and its tests run on their own, and its CI is green today. The endpoint the button calls is added in apache#8327: until that lands, clicking it reports that the request failed and nothing else changes, so the order here is a preference rather than a constraint. Closes apache#8427, the task this change is the whole of. ### What it looks like The toolbar without this change, and with it. The new control is the sixth, between the download and the info buttons. <img width="549" height="48" alt="toolbar before" src="https://github.com/user-attachments/assets/434cd8d5-16ca-4ff1-ad4f-7244656110c3" /> <img width="549" height="48" alt="toolbar after" src="https://github.com/user-attachments/assets/f2d3c617-71fa-44f6-ac7f-9cd854ebe36f" /> Clicking it asks the compiling service to translate the canvas and shows what comes back, with a control that copies the script. <img width="1354" height="896" alt="the export modal" src="https://github.com/user-attachments/assets/0b119b15-5ca9-43e8-afd1-098f5fa34f8b" /> ### How was this PR tested? `yarn --cwd frontend run test:ci`, which is what CI runs; a single spec is `yarn --cwd frontend ng test --watch=false --include=<path>`. `menu.component.spec.ts` covers the three ways the export click can end: the script coming back, the translator refusing the plan, and the request failing. `context-menu.component.spec.ts` covers the execute-to-here entry under a failed compilation. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 5) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The property panel reads the constraints the schema declares.
A column property is checked against the attribute type rule for every column it names rather than only the first. A hyperparameter's value renders as the control its parameter implies: a dropdown where the accepted set is known, a number input where it is numeric, a plain text box where the rules say nothing. A property declared unique among rows says which row already holds the value, and a row deleted clears the error it left behind, since deleting a row changes no surviving control's value and the row left behind would otherwise keep an error about a duplicate that is no longer there.
#8350 is the export button; this one is a separate thread of work.
Any related issues, documentation, discussions?
Part of #8325, 26 of 27; that issue lists the set in order.
Closes #8510, the task this change is the whole of.
Supersedes #7983, #7980 and the frontend half of #7946, which are closed in favour of this. They touched the same three files, so reviewing them apart meant reading the same code more than once and resolving a conflict between them at merge.
Closes #7981. Part of #7979, #7952 and #7936, whose remaining half is in #8348; those three stay open until both land, since each is only fixed once the schema declares the rule and the panel enforces it.
How was this PR tested?
formly-utils.spec.tscovers the mapping from a declared rule to a control and the type checking across every named column.constrained-value.component.spec.tscovers what each control renders.operator-property-edit-frame.component.spec.tsdrives the rendered form, including the click that deletes a duplicate row and the error it has to clear.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
🤖 Generated with Claude Code