feat(frontend): add the on-canvas per-execution warehouse picker

[mengw15]

What changes were proposed in this PR?

The workspace-side half of per-user warehouses (#6870): a warehouse picker on the canvas, beside the computing-unit selector it mirrors, choosing which warehouse the next execution writes to.

• The picker (inside ComputingUnitSelectionComponent, like the computing-unit dropdown it sits beside) — shown only while the deployment enables the feature; each entry carries the owner avatar and a per-row delete, plus a create entry opening the shared create dialog. The list refreshes on every dropdown open, and preselection picks the latest execution's warehouse, falling back to the user's first one — so a run needs no explicit pick. A status failure clears the pick rather than letting a stale id ride the next request.
• Run gating — with the feature enabled, every execution must have a warehouse: while none is selected the Run button becomes "Create Warehouse" and leads to the create dialog, the same shape as the Connect flow. (The backend-side requirement follows separately — [BYO-S3] Require a warehouse for every execution while the feature is enabled #7751 stays the tracker.)
• The request — the picked warehouseId rides the execute request (ExecuteWorkflowService reads the pick from WarehouseService, where it lives); executions expose whId so the preselect can read the latest run's warehouse.

Flag off (the default): the picker never renders, the Run button is untouched, and requests carry no warehouseId — no user-visible change.

demo

Screen.Recording.2026-09-16.at.3.18.52.PM.mov

Any related issues, documentation, discussions?

Closes #7817. Part of #6870, on top of the dashboard tab (#8005); the backend enforcement (#7751) follows.

How was this PR tested?

• 20 new Vitest tests: 15 on the picker (preselect from the latest execution, first-warehouse fallback, disabled/failed states clearing the pick, manual pick surviving refreshes, create/delete flows, dropdown rendering), 3 on the Run gating, 1 pinning warehouseId on the execute request, 1 on the selection state. One pre-existing assertion modernized: the remembered-unit test asserted the latest-execution lookup's absence, which the warehouse preselect now legitimately performs — it asserts the unit choice directly instead.
• The affected suites pass in full: 5083 tests across the workspace and dashboard trees.
• Failure paths verified rather than assumed: the preselect, the Run gating, and the request field were each broken on purpose and the suite confirmed to fail for the expected reason before being restored.
• Screenshots/video from a local flag-on deployment follow in the comments.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (claude-opus-5, claude-fable-5)

[github-actions]

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

• Contributors with relevant context: @yangzhang75, @kunwp1, @Neilk1021
  You can notify them by mentioning @yangzhang75, @kunwp1, @Neilk1021 in a comment.

[Copilot]

🟡 Changes recommended

Warehouse state races and fail-open behavior can select the wrong warehouse or allow executions without one.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds a feature-gated warehouse picker to the workspace and attaches the selected warehouse to workflow executions.

Changes:

• Adds warehouse selection, creation, deletion, and preselection.
• Gates Run when no warehouse is selected.
• Includes warehouseId in execution requests and expands test coverage.

File summaries

File	Description
execute-workflow.service.ts	Adds warehouse ID to execution requests.
execute-workflow.service.spec.ts	Tests request serialization.
computing-unit-selection.component.ts	Implements warehouse picker state and actions.
computing-unit-selection.component.spec.ts	Tests picker behavior.
computing-unit-selection.component.scss	Styles the picker.
computing-unit-selection.component.html	Renders picker and creation modal.
menu.component.ts	Adds missing-warehouse Run gating.
menu.component.spec.ts	Tests Run behavior.
workflow-executions-entry.ts	Exposes execution warehouse ID.
workflow-execution-history.component.spec.ts	Updates execution fixtures.
warehouse.service.ts	Stores the current warehouse selection.
warehouse.service.spec.ts	Tests selection state.

Review details

Suppressed comments (2)

frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts:480

• A status failure is treated as feature-disabled, then the selected ID is cleared. Consequently warehouseRequiredButMissing becomes false and runWorkflow() proceeds with warehouseId: undefined; until #7751 lands, an enabled deployment silently writes that run to shared storage. Keep an explicit failed/loading state and fail closed (disable or retry Run) unless the status request successfully reports enabled: false.

        error: (err: unknown) => {
          // The pick lives in the root-scoped service, so hiding the picker is not
          // enough: a stale id from a previous workflow would still ride the next
          // execution request. Clear it whenever the picker cannot be shown.
          this.warehouseEnabled = false;
          this.warehouses = [];
          this.warehouseService.selectWarehouse(undefined);

frontend/src/app/workspace/component/power-button/computing-unit-selection.component.html:126

• Adding role="button" to an <i> does not make it keyboard-operable: this delete action cannot receive focus or be activated with Enter/Space. Prefer a real <button type="button">, or add tabindex="0" plus equivalent keyboard handlers.

            role="button"
            aria-label="Delete warehouse">

• Files reviewed: 12/12 changed files
• Comments generated: 4
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 93.07692% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.92%. Comparing base (dcf8217) to head (5b76637).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
...wer-button/computing-unit-selection.component.html	87.80%	3 Missing and 2 partials ⚠️
...rvice/execute-workflow/execute-workflow.service.ts	85.71%	1 Missing and 1 partial ⚠️
...src/app/workspace/component/menu/menu.component.ts	90.90%	1 Missing ⚠️
...power-button/computing-unit-selection.component.ts	98.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8551      +/-   ##
============================================
- Coverage     92.93%   92.92%   -0.02%     
  Complexity     4885     4885              
============================================
  Files          1231     1235       +4     
  Lines         51468    51966     +498     
  Branches       6327     6389      +62     
============================================
+ Hits          47833    48287     +454     
- Misses         2073     2105      +32     
- Partials       1562     1574      +12     

Flag	Coverage Δ		*Carryforward flag
access-control-service	71.78% <ø> (ø)		Carriedforward from 6ab9fee
agent-service	99.32% <ø> (ø)		Carriedforward from 6ab9fee
amber	89.02% <ø> (ø)		Carriedforward from 6ab9fee
computing-unit-managing-service	54.61% <ø> (ø)		Carriedforward from 6ab9fee
config-service	87.37% <ø> (ø)		Carriedforward from 6ab9fee
file-service	81.53% <ø> (ø)		Carriedforward from 6ab9fee
frontend	96.57% <93.07%> (-0.12%)	⬇️
notebook-migration-service	83.73% <ø> (ø)		Carriedforward from 6ab9fee
pyamber	98.47% <ø> (ø)		Carriedforward from 6ab9fee
workflow-compiling-service	74.09% <ø> (ø)		Carriedforward from 6ab9fee

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

🟡 Changes recommended

Status failures can bypass warehouse gating, and asynchronous preselection can overwrite a manual choice.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

frontend/src/app/workspace/component/power-button/computing-unit-selection.component.html:127

• This icon has role="button" but is neither focusable nor keyboard-operable, so keyboard users cannot invoke the destructive action. Add tab focus plus Enter/Space handlers (including propagation prevention so the menu row is not selected).
  frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts:541
• A manual choice does not invalidate the in-flight latest-execution lookup. If the user selects a row before either lookup callback runs, applyWarehousePreselect() later overwrites that explicit choice with the historical/default warehouse. Track a workflow/request generation (or whether the user has selected since lookup start) and ignore preselection callbacks after a manual pick.

• Files reviewed: 12/12 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

Several execution entry points bypass the warehouse gate and can still submit without a warehouse.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (3)

Previously missed (3) — in code that hasn't changed since the last review.

frontend/src/app/workspace/component/power-button/computing-unit-selection.component.html:101

• This class has no corresponding style rule and does not set Ng Zorro's menu-item selection state, so the open menu exposes no visual or ARIA indication of the current warehouse. Bind the menu item's nzSelected input instead.
  frontend/src/app/workspace/component/power-button/computing-unit-selection.component.html:127
• This delete control is mouse-only: role="button" does not make the icon focusable or activate it from the keyboard. Add focusability and Enter/Space handlers (including propagation prevention so deletion does not select the row).
  frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts:605
• After deletion succeeds, this callback starts another HTTP request but leaves the deleted warehouse selected until that request returns. During that window Run remains enabled and can submit the now-invalid ID; if the refresh stalls, the stale selection persists. Clear the selected ID synchronously when the deleted warehouse was selected, then refresh to choose the fallback.

• Files reviewed: 12/12 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

Warehouse preselection, deletion timing, execution-state resets, and keyboard accessibility have unresolved defects.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (3)

Previously missed (3) — in code that hasn't changed since the last review.

frontend/src/app/workspace/component/power-button/computing-unit-selection.component.html:126

• role="button" does not make this <i> keyboard-focusable or activate it with Enter/Space, so keyboard-only users cannot delete a warehouse. Use a real button, or add tabindex="0" plus Enter/Space handlers that invoke the same confirmation without selecting the row.
  frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts:388
• This lookup is still coupled to the computing-unit list becoming nonempty. If the workflow has a remembered CU that was terminated and the user currently has zero units, the filter(units => units.length > 0) above never emits, so the latest execution is never queried and the warehouse refresh permanently leaves the first warehouse selected instead of the latest execution's warehouse. Start warehouse preselection independently of the CU-list wait.
  frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts:601
• After a selected warehouse is successfully deleted, this callback starts an asynchronous refresh but leaves the deleted ID selected until that request returns. A run during that interval sends a warehouse ID that is guaranteed not to exist. Clear the selection synchronously in the delete-success callback before refreshing.

• Files reviewed: 12/12 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

Unsaved workflows can lose automatic preselection, and the delete control is not keyboard accessible.

Review details

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

frontend/src/app/workspace/component/power-button/computing-unit-selection.component.html:127

• This delete control has role="button" but is not focusable or keyboard-activatable, so keyboard-only users cannot delete a warehouse. Add focus and Enter/Space activation (or use a native button) while continuing to stop propagation to the parent menu item.
  frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts:352
• Switching to a new unsaved workflow (wid === DEFAULT_WORKFLOW.wid) clears the warehouse selection and then skips every preselection path. If the warehouse list was already loaded, the Run button therefore offers “Create Warehouse” even when the user already has warehouses, until they manually reopen the dropdown. Apply the first-warehouse fallback immediately for the default workflow.

• Files reviewed: 12/12 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[Ma77Ball]

Review summary

This is the workspace-side half of per-user warehouses (#6870): a warehouse picker inside ComputingUnitSelectionComponent beside the computing-unit dropdown, Run-button gating that redirects to a create-warehouse modal when a warehouse is required but missing, and a warehouseId on the execute request. The change is well structured and mirrors the existing computing-unit patterns closely; the concurrency handling (a single switchMap'd refresh stream, preselect re-running after whichever of the list/latest-execution responses lands last, fail-closed on a status error) is careful and matches the extensive tests. The pick lives in the root-scoped WarehouseService and is cleared on workflow switch, on status failure, and when nothing is selectable, so a stale id cannot ride the next request. I verified the contract holds on the backend side: /executions/{wid}/latest serializes whId, and WorkflowExecuteRequest already declares warehouseId: Option[Int], so nothing here breaks execution. No blocking issues.

The one real gap is behavioral: the Run-button gate sits ahead of the execution-state switch, so it can replace Pause/Kill while a workflow is actively running (see below). Flag-off behavior is a clean no-op as described.

Action items: Nothing blocking. Consider the P2 (don't let the warehouse gate hide Pause/Kill mid-run) before merge; the P3 is optional.

---

Findings

2 total: 0 P0, 0 P1, 1 P2, 1 P3.

Non-blocking (P2)

• Don't let the warehouse gate override Pause/Kill during an active execution - frontend/src/app/workspace/component/menu/menu.component.ts:427 - see inline.

Nit (P3)

• Run-gate reads a different "enabled" signal than the picker - frontend/src/app/workspace/service/execute-workflow/execute-workflow.service.ts:252 - see inline.

---

Verification

• P2 (button gate vs active execution): with the feature enabled and a workflow Running (or Paused), deleting the currently-selected warehouse via the picker's delete icon calls confirmDeleteWarehouse -> refreshWarehouses -> applyWarehousePreselect; if it was the only/last warehouse, selectWarehouse(undefined) runs, so warehouseRequiredButMissing flips to true. getRunButtonBehavior checks that before the executionState switch, so the button becomes "Create Warehouse" and the user loses Pause/Kill on the in-flight run. Narrow trigger, real loss of control.
• P3 (dual enabled source): confirmed both status.enabled (picker) and config.env.warehouseEnabled (execute-service gate) derive from the same StorageConfig.warehouseEnabled today, so they cannot diverge on a real deployment - hence P3, not a bug.
• Not run: I did not execute the Vitest suites; findings are from static reading of the PR at head plus the backend contract at the same ref.

[kunwp1]

LGTM!