Repository navigation
Conversation
Contributor
Backport auto-label reportThis
|
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8796 +/- ##
=========================================
Coverage 92.58% 92.58%
Complexity 4963 4963
=========================================
Files 1242 1242
Lines 52885 52885
Branches 6546 6546
=========================================
Hits 48965 48965
Misses 2291 2291
Partials 1629 1629
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 510 | 0.311 | 19,243/23,558/23,558 us | 🟢 -13.7% / 🔴 +55.1% |
| 🔴 | bs=100 sw=10 sl=64 | 1,163 | 0.71 | 81,184/125,677/125,677 us | 🔴 +33.7% / 🔴 +18.4% |
| 🔴 | bs=1000 sw=10 sl=64 | 1,374 | 0.839 | 726,535/790,399/790,399 us | 🔴 +6.0% / 🟢 +26.4% |
Baseline details
Latest main 98d3d4b from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 510 tuples/sec | 576 tuples/sec | 818.62 tuples/sec | -11.5% | -37.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.311 MB/s | 0.351 MB/s | 0.5 MB/s | -11.4% | -37.8% |
| bs=10 sw=10 sl=64 | p50 | 19,243 us | 17,547 us | 12,404 us | +9.7% | +55.1% |
| bs=10 sw=10 sl=64 | p95 | 23,558 us | 27,289 us | 15,787 us | -13.7% | +49.2% |
| bs=10 sw=10 sl=64 | p99 | 23,558 us | 27,289 us | 18,928 us | -13.7% | +24.5% |
| bs=100 sw=10 sl=64 | throughput | 1,163 tuples/sec | 1,225 tuples/sec | 1,058 tuples/sec | -5.1% | +9.9% |
| bs=100 sw=10 sl=64 | MB/s | 0.71 MB/s | 0.748 MB/s | 0.646 MB/s | -5.1% | +9.9% |
| bs=100 sw=10 sl=64 | p50 | 81,184 us | 81,084 us | 99,149 us | +0.1% | -18.1% |
| bs=100 sw=10 sl=64 | p95 | 125,677 us | 93,993 us | 106,165 us | +33.7% | +18.4% |
| bs=100 sw=10 sl=64 | p99 | 125,677 us | 93,993 us | 114,997 us | +33.7% | +9.3% |
| bs=1000 sw=10 sl=64 | throughput | 1,374 tuples/sec | 1,416 tuples/sec | 1,088 tuples/sec | -3.0% | +26.3% |
| bs=1000 sw=10 sl=64 | MB/s | 0.839 MB/s | 0.864 MB/s | 0.664 MB/s | -2.9% | +26.4% |
| bs=1000 sw=10 sl=64 | p50 | 726,535 us | 706,130 us | 971,066 us | +2.9% | -25.2% |
| bs=1000 sw=10 sl=64 | p95 | 790,399 us | 745,896 us | 1,011,680 us | +6.0% | -21.9% |
| bs=1000 sw=10 sl=64 | p99 | 790,399 us | 745,896 us | 1,037,719 us | +6.0% | -23.8% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,392.01,200,128000,510,0.311,19242.64,23557.64,23557.64
1,100,10,64,20,1720.00,2000,1280000,1163,0.710,81184.16,125676.63,125676.63
2,1000,10,64,20,14553.51,20000,12800000,1374,0.839,726534.71,790398.99,790398.99This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Drain the small UTF-16 fixture in finally so the lazy reader closes before file deletion. Keep the decoding assertions and exhausted-iterator check. This repairs one test; no production behavior changes.
Any related issues, documentation, discussions?
Closes #8795
How was this PR tested?
On Windows: baseline 13 passed and one failed; patched 14 passed. A temporary wrong-encoding mutation still failed the decoding assertion. The scan suites passed 163 tests with one existing S3 fixture cancellation. Formatting and lint passed.
Localhost Chrome at 1707 by 979 also ran the unchanged UTF-16 reader and returned the three expected lines.
These local checks preceded the September 30 rebase onto upstream main 98d3d4b. These historical results do not include the review fixes below. The full operating-system matrix is not claimed.
Test-only change. This screenshot is a compatibility check, not a visual before and after.
Independent review follow-up — September 30
Rechecked fixture ownership and iterator exhaustion before deletion. The change only drains the three-line lazy fixture so its Windows file handle closes. No additional defect identified; no production change or fresh test run is claimed in this review. The existing screenshot remains explicitly a compatibility check.
Release-backport approval is still required. The earlier build jobs were cancelled; requesting a rerun was denied for lack of repository admin rights. Approval requirements and release labels were left intact.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex, model gpt-6-astra. The authoring session records Codex version 0.148.0-alpha.15; later runtime versions were not recorded.