Repository navigation
feat(workflow-operator): volcano plot hover column - #9042
Open
eugenegujing wants to merge 1 commit into
Open
eugenegujing wants to merge 1 commit into
eugenegujing wants to merge 1 commit into
Conversation
Add an optional Hover column property, as on Scatter Plot, used as the hover label of each point. An empty or blank field keeps the first input column as before; a set column missing from the input yields the operator's error page.
Contributor
Automated Reviewer SuggestionsBased on the
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The Volcano Plot uses
hover_name=table.columns[0], so the tooltip label is whatever column comes first in the input. That is fine for a DESeq2 table starting withgeneand useless for one starting with a composite id or a number, and there is no way to change it. This PR copies Scatter Plot'sHover columnproperty over, one column only.hover_name=table.columns[0], unchanged for saved workflowshover_name=<that column>Missing hover column in table., like the existing check for the two required columns (Scatter Plot lets plotly raise aValueErrorhere)Independent of the label-fix (#9037) and significance-threshold (#9039) PRs; all three touch neighbouring lines of
VolcanoPlotOpDesc.scala, so whichever lands second needs a small rebase.Figures below are the operator's generated Python from
mainand from this branch (Hover column =gene), run on the 430-gene example workflow from the issue whose first column istranscript|gene|chr|strand; the same point is hovered in both.Any related issues, documentation, discussions?
Closes #9038
PR #8504 adds a
generateStandaloneCode()path to this operator that copies the current template, includinghover_name=table.columns[0]. Whichever lands first, the other needs a follow-up.How was this PR tested?
New tests in
VolcanoPlotOpDescSpec, written before the source change:hover_name=table.columns[0]and emits no hover checkhover_nameplus the presence check, and notable.columns[0]Smoke run outside Texera (pytexera stubbed, pandas + plotly 5.24.1) on the 430-gene mock table: defaults hover-label the first point as
ENST00000000000|GENE_0000|chr2|+; Hover column =genegivesGENE_0000; Hover column =no_such_columnyields<h1>Volcano Plot failed</h1><p>Missing hover column in table.</p>.Was this PR authored or co-authored using generative AI tooling?
Yes. Generated-by: Claude Code (claude-fable-5-1). Co-authored with Claude; the author reviewed the change before submission.