Skip to content

[ZEPPELIN-6362] Add E2E coverage for interpreter configuration - #5612

Merged
voidmatcha merged 2 commits into
apache:masterfrom
miinhho:ZEPPELIN-6362-interpreter-e2e
Nov 14, 2026
Merged

voidmatcha merged 2 commits into
apache:masterfrom
miinhho:ZEPPELIN-6362-interpreter-e2e

Conversation

@miinhho

@miinhho miinhho commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

What is this PR for?

Add Playwright E2E coverage for the existing Angular interpreter route before future React migration work.

Cover:

  • Direct navigation, reload, settings display and case-insensitive search.
  • Interpreter creation, required fields, duplicate names and group defaults.
  • Typed properties, dependency editing and cancellation.
  • Binding options, impersonation and conditional process and permission fields.
  • Restart and removal confirmations, including cancellation.
  • Repository display, protected defaults, tooltips and add/remove workflows.
  • Repository form validation, URL protocols, credentials and proxy settings.

Tests use real server reads by default. Endpoint-specific stubs provide controlled states that are not guaranteed in the default environment. Mutation requests are intercepted to avoid persisting configuration changes or restarting interpreters.

What type of PR is it?

Improvement

What is the Jira issue?

How should this be tested?

With the Zeppelin server running at http://localhost:8080, run from zeppelin-web-angular:

npm run e2e:fast -- tests/workspace/interpreter --retries=0

Questions:

  • Does the license files need to update? No.
  • Is there breaking changes for older versions? No.
  • Does this needs documentation? No.

@voidmatcha voidmatcha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While investigating locally, I found that the modal's autofocus handling can race with input while the modal is opening. In a reduced browser reproduction using the actual form, delaying text insertion left the ID empty in all three runs. With nzAutofocus: null, all three runs succeeded. I have not confirmed that this caused the CI failure.

Autofocus also serves keyboard accessibility, so we should consider both the initial focus when the modal opens and preserving focus once the user starts interacting. It may be worth addressing this separately in a follow-up issue.

For this PR, could we add assertions for the ID value immediately after filling it and again after filling the URL? This would not resolve the race itself, but it would identify an input failure closer to where it occurs.

@miinhho

miinhho commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

While investigating locally, I found that the modal's autofocus handling can race with input while the modal is opening. In a reduced browser reproduction using the actual form, delaying text insertion left the ID empty in all three runs. With nzAutofocus: null, all three runs succeeded. I have not confirmed that this caused the CI failure.

Autofocus also serves keyboard accessibility, so we should consider both the initial focus when the modal opens and preserving focus once the user starts interacting. It may be worth addressing this separately in a follow-up issue.

For this PR, could we add assertions for the ID value immediately after filling it and again after filling the URL? This would not resolve the race itself, but it would identify an input failure closer to where it occurs.

Thanks for investigating. I’ve added assertions to check the ID immediately after filling it and again after filling the URL. I also opened ZEPPELIN-6771 to track the autofocus issue separately, including preserving keyboard accessibility.

@voidmatcha voidmatcha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@voidmatcha
voidmatcha merged commit 3ce7b63 into apache:master Nov 14, 2026
24 checks passed
@voidmatcha

Copy link
Copy Markdown
Member

Merged into master (3ce7b63).

@miinhho
miinhho deleted the ZEPPELIN-6362-interpreter-e2e branch November 14, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants