Repository navigation
[ZEPPELIN-6362] Add E2E coverage for interpreter configuration - #5612
Conversation
voidmatcha
left a comment
There was a problem hiding this comment.
While investigating locally, I found that the modal's autofocus handling can race with input while the modal is opening. In a reduced browser reproduction using the actual form, delaying text insertion left the ID empty in all three runs. With nzAutofocus: null, all three runs succeeded. I have not confirmed that this caused the CI failure.
Autofocus also serves keyboard accessibility, so we should consider both the initial focus when the modal opens and preserving focus once the user starts interacting. It may be worth addressing this separately in a follow-up issue.
For this PR, could we add assertions for the ID value immediately after filling it and again after filling the URL? This would not resolve the race itself, but it would identify an input failure closer to where it occurs.
Thanks for investigating. I’ve added assertions to check the ID immediately after filling it and again after filling the URL. I also opened ZEPPELIN-6771 to track the autofocus issue separately, including preserving keyboard accessibility. |
|
Merged into master (3ce7b63). |
What is this PR for?
Add Playwright E2E coverage for the existing Angular interpreter route before future React migration work.
Cover:
Tests use real server reads by default. Endpoint-specific stubs provide controlled states that are not guaranteed in the default environment. Mutation requests are intercepted to avoid persisting configuration changes or restarting interpreters.
What type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
With the Zeppelin server running at
http://localhost:8080, run fromzeppelin-web-angular:Questions: